This repository has been archived by the owner on Oct 9, 2019. It is now read-only.
removal round 2 #77
Merged
removal round 2 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not merge without @nzlz feedback |
ahcorde
suggested changes
May 8, 2019
|
I think ive seen that demo file referenced somewhere in the docs, but i agree we should remove that. Ill update the docs if i find it. Regarding the mara state publisher, isnt rviz fed using the robot state publisher and not this script? Ill take a deeper look tomorrow if this PR is not solved by then. Other removals / mods look fine. |
|
What is the status of this one @ahcorde? can we accept this? |
LanderU
approved these changes
May 9, 2019
rkojcev
approved these changes
May 9, 2019
|
Can be merged? |
LanderU
approved these changes
May 10, 2019
|
I would say yes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.