Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to use custom query string manager #54

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Ability to use custom query string manager #54

merged 1 commit into from
Jun 15, 2021

Conversation

igieon
Copy link
Contributor

@igieon igieon commented Jun 10, 2021

  • documentation
  • tests

@igieon igieon mentioned this pull request Jun 11, 2021
Merged
mahenzon
mahenzon requested changes Jun 11, 2021
View reviewed changes
Copy link
Collaborator

@mahenzon mahenzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Cool feature, but tests need some minor updates

tests/test_sqlalchemy_data_layer.py Outdated Show resolved Hide resolved
tests/test_sqlalchemy_data_layer.py Outdated Show resolved Hide resolved
tests/test_sqlalchemy_data_layer.py Outdated Show resolved Hide resolved
tests/test_sqlalchemy_data_layer.py Show resolved Hide resolved
tests/test_sqlalchemy_data_layer.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 11, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 938389004

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 83.056%
Totals Coverage Status
Change from base Build 920880177: 0.2%
Covered Lines: 1299
Relevant Lines: 1564
💛 - Coveralls

@igieon igieon requested a review from mahenzon June 15, 2021 07:11
mahenzon
mahenzon approved these changes Jun 15, 2021
View reviewed changes
Copy link
Collaborator

@mahenzon mahenzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

tests/test_sqlalchemy_data_layer.py Show resolved Hide resolved
@mahenzon mahenzon merged commit 620a96f into AdCombo:master Jun 15, 2021
@igieon igieon deleted the custom_query_manager branch June 15, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahenzon mahenzon mahenzon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igieon @coveralls @mahenzon