Ensure that status message is included on status line #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahenzon
reviewed
Aug 3, 2023
|
@roman-adcombo Will you lunch a new release with these changes? When I run |
sure, we need to fix deploy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where all API errors would result in an internal server error under Apache's mod_wsgi.
The code currently returns a status line consisting of just the numeric code, i.e.
400rather than400 BAD REQUEST. This results in an error ofValueError: no space following status codefrom mod_wsgi.This PR fixes this by casting the status to an integer if it is just an integer, which prompts Flask to fill in the rest of the status line.