Some maintenance updates #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* underspecs allows for stricts typespecs, which is good * no_return prevents a class of warnings we might want to be aware of
Also adds a much-deserved badge to README.md
We also add `no_unknown` to Dialyzer (because `unknown` is default in OTP 26), so we can fix errors locally without having to wait for CI (if locally you're using OTP 25, and CI fails in OTP 26, that is)
|
I guess you need to tweak branch settings for this to move forward... 
|
elbrujohalcon
approved these changes
Aug 21, 2023
|
I'm seeing double 😄 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We bump the minimum to 24, even though CI is set to 25 and there are Dialyzer options that make
rebar3 dialyzerfail under 24. If you prefer we can push the minimum to 25.