Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename unused_ignored_function_params rule #69

Closed
pbrudnick opened this issue Jan 27, 2021 · 0 comments · Fixed by #78
Closed

Rename unused_ignored_function_params rule #69

pbrudnick opened this issue Jan 27, 2021 · 0 comments · Fixed by #78
Assignees
@elbrujohalcon
Labels
enhancement New feature or request started
Milestone
0.3.0

Comments

@pbrudnick
Copy link
Collaborator

This rule is causing confusion, it collides with unused function params which are detected by the compiler.
The rationale of the rule won’t change, but we can turn its name and warning message more comprehensive:

The rule name can turn to: unnecessary_function_argument
And the warning message to: fun/4 doesn’t need it’s #4 argument
@pbrudnick pbrudnick added the enhancement New feature or request label Jan 27, 2021
@pbrudnick pbrudnick added this to the 0.3.0 milestone Jan 27, 2021
@elbrujohalcon elbrujohalcon self-assigned this Feb 23, 2021
elbrujohalcon added a commit that referenced this issue Feb 23, 2021
@elbrujohalcon
Fix #69: Rename unnecessary_function_arguments rule
7dd9c1a
@elbrujohalcon elbrujohalcon mentioned this issue Feb 23, 2021
Merged
elbrujohalcon pushed a commit that referenced this issue Feb 23, 2021
Fix #69: Rename unnecessary_function_arguments rule (#78)
db16f43 
* Fix #69: Rename unnecessary_function_arguments rule

* Fix #79: NIF check crashing

* A bit of cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elbrujohalcon elbrujohalcon

Labels
enhancement New feature or request started
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Fix #69: Rename unnecessary_function_arguments rule AdRoll/rebar3_hank
2 participants
@elbrujohalcon @pbrudnick