Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ports - Faiza #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ports - Faiza #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74ba579
Completed factorial
Faiza1987 Apr 11, 2019
d07f594
Added space/time complexity
Faiza1987 Apr 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions lib/factorial.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,18 @@
# Computes factorial of the input number and returns it
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(n) where n is the number
Copy link

@pmanni02 pmanni02 Apr 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the space complexity constant?

# Space complexity: O(1)
def factorial(number)
raise NotImplementedError
# raise NotImplementedError
if number == nil
raise ArgumentError
end

i = 1
while number > 0
i = number * i
number -= 1
# i += 1
end

return i
end