Sockets - Cyndi #18
Open
Sockets - Cyndi #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-andeen
reviewed
Apr 19, 2019
There was a problem hiding this comment.
The code looks pretty good, but your solution has exponential time complexity. Fibonacci can be calculated in linear time with either an iterative or a recursive approach, which is obviously way better than exponential.
You should rewrite this to find a linear-time solution.
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # n is the input number | ||
| # Time complexity: O(2n), since 2n steps will be needed. |
There was a problem hiding this comment.
Incorrect. Each function call generates two additional function calls, so time complexity is really O(2^n).
| if n == 0 | ||
| return 0 | ||
| elsif n == 1 | ||
| # p "n = 1" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.