Ports - Ngoc #21
Ports - Ngoc #21
Conversation
| if n == 0 | ||
| return 0 | ||
| else | ||
| p1 = 0 |
There was a problem hiding this comment.
[nit] Why p? (Not that you should change it, it's just not obvious to me.)
There was a problem hiding this comment.
You have a good point. Do you think naming it p3 would make it easy to understand, since it is the number subsequent to p2 ?
There was a problem hiding this comment.
I was actually curious why you were using p1 and p2 and p3. What's the "p" for?
| @@ -5,8 +5,23 @@ | |||
| # .... | |||
| # e.g. 6th fibonacci number is 8 | |||
|
|
|||
| # Time complexity: ? | |||
| # Space complexity: ? | |||
| # Time complexity: O(n), n is the number of computations this calculation needs to run to compute the nth fibonacci number | |||
There was a problem hiding this comment.
"the number of computations this calculation needs to run" is sort of what you're trying to define by explaining the "time complexity" of a method, so you don't want to use that in the definition. "n" as you're using it here is actually the value of the input variable n. The time complexity is n because you're iteratively calculating each fibonacci number up to n.
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n), n is the number of computations this calculation needs to run to compute the nth fibonacci number | ||
| # Space complexity: O(1), space complexity is constant because this method only require a storage for 3 variables (p,p1,p2) regardless of number of operations |
No description provided.