Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ports - Jessica #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ports - Jessica #33

wants to merge 1 commit into from

Conversation

jessicacaley
Copy link

No description provided.

CheezItMan
CheezItMan reviewed May 12, 2019
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution works and is pretty good. The running code has a time complexity of O(n) and a space complexity of O(n) as well.

Your commented out code is actually better in terms of space complexity.

lib/fibonacci.rb
@@ -7,6 +7,37 @@

# Time complexity: ?
# Space complexity: ?

## this works but feels bad
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't feel bad about this solution. It's pretty good. It actually uses less memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessicacaley @CheezItMan