Sockets - Shubha

[shubha-rajan]

Portmanteau Generator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
What went well in your code style, such as indentation, spacing, variable names, readability, etc.? What was lacking?	I think the indentation, spacing and variable names are all clear, but my code could probably use more comments.
How did creating the is_vowel? method affect your project?	The 'is_vowel?' method allowed me to quickly write code to do other things that required vowel checking without having to repeat my code for checking vowels
What was your strategy for getting the correct set of letters from the first word into the portmanteau?	I looped through the first word to find an end index by starting with an index equal to (word.length - 1) and incrementing backwards, breaking out of the loop once a vowel was identified. I then looped through the second word to find a start index, and then used the string.slice method to get the word parts, which I joined together to create my portmanteau.
What was your strategy for validating against inputs under 2 characters?	I used an until loop which kept prompting the user to enter another input until the input length was greater than or equal to 2.
In the next project, what would you change about your process? What would you keep doing?	I'm hoping to learn to use the debugger in VSCode and make use of that instead of running buggy/not working code and messing with it semi-blindly until it stops throwing errors.

[shubha-rajan]

Grade the one that's named generator.rb please! :) I uploaded the other files just so I could have them in my repo.

[dHelmgren]

Portmanteau Generator

What We're Looking For

Feature	Feedback
Readable code with consistent indentation	Looked good!
Practices using variables appropriately	Yes!
Practices using conditionals appropriately	Yes
Practices iteration appropriately	Yes
Practices using custom methods appropriately	Yes
Program validates against input under 2 characters	Yes
Takes in two inputs and creates a portmanteau	Yes!

[dHelmgren]

Great work! In the future, just turn in your most-complete version, as I use a tool to help me grade. I didn't know you had 3 files in here until I looked on github!

[dHelmgren]

I would delete this dead code! It just muddies the waters when someone goes to look through it.

[dHelmgren]

nice trick!

[dHelmgren]

So, personal style note, I'd move this function to the top of the code, because it gives context to what happens in your main program. Remember, your jobs are to 1) make it work good and 2) make it as easy to grok as possible.