Sockets - Carla

[carlabosco]

Portmanteau Generator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
What went well in your code style, such as indentation, spacing, variable names, readability, etc.? What was lacking?	I believe I was careful with the format, but please let me know where I could improve. My code was initially doing an unnecessary loop, but Devin already gave me feedback on it and I updated my code.
How did creating the is_vowel? method affect your project?	That was very helpful in making my code less verbose, as I could just reuse this method when needed.
What was your strategy for getting the correct set of letters from the first word into the portmanteau?	I iterated the word starting from the last character until the first vowel was found. At this point, the code would break out of the loop and set the new word segment from the first character index until the index of the last vowel, excluding the last vowel.
What was your strategy for validating against inputs under 2 characters?	I created an if statement to count the number of vowels in the word. If no vowels are found, the code jumps to the else statement where the string manipulation is made.
In the next project, what would you change about your process? What would you keep doing?	I would definitely make better use of pseudo code. I would also make use of "puts" early on to help me debug quicker.

[droberts-sea]

Portmanteau Generator

What We're Looking For

Feature	Feedback
Readable code with consistent indentation	yes
Practices using variables appropriately	yes
Practices using conditionals appropriately	yes
Practices iteration appropriately	yes
Practices using custom methods appropriately	yes
Program validates against input under 2 characters	yes
Takes in two inputs and creates a portmanteau	yes

Great job overall! I've left a few comments inline below where things could be cleaned up, but in general I am quite happy with this project. Keep up the hard work!

[droberts-sea]

Your code to get the second word is almost exactly the same as the code to get the first word. Could you DRY this up using another method?

[droberts-sea]

Good use of a constant and of .include? here.

[droberts-sea]

In Ruby, we typically name variables using all lowercases letters, so this would be word_a.