Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets - Grace #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sockets - Grace #35

wants to merge 1 commit into from

Conversation

gracemshea
Copy link

Portmanteau Generator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What went well in your code style, such as indentation, spacing, variable names, readability, etc.? I really liked building method boxes and just referring back to them. I felt like it kept my zones really organized. Previously, I feel like I did messier embedded methods that made sense only to myself and me.
What was lacking? My program does not allow for vowel-less words. Maybe that was a little snarky of me, but within my valid_test method, I rejected quite a bit of possible inputs. I could've gone through confronting those possibilities.
How did creating the is_vowel? method affect your project? I referred back to this function when making first half and second half of pormanteau. I am not sure how to achieve this project without the is_vowel method, it was essential and referring to it instead of having it embedded kept everything comprehensible as well.
What was your strategy for getting the correct set of letters from the first word into the portmanteau? I used reverse index with each_char to begin indexing and the end of the word. I sliced from that position.
What was your strategy for validating against inputs under 2 characters? I rejected them within my valid_test method.
In the next project, what would you change about your process? What would you keep doing? I googled abundantly. It's been pretty much how I've been coding thus far. I don't think it's wrong, I just need to stay attentive and maybe not try to learn toooooo much new stuff at once or it will take me forever to figure out how each and every new component works.

@droberts-sea
Copy link

Portmanteau Generator

What We're Looking For

Feature Feedback
Readable code with consistent indentation yes
Practices using variables appropriately yes
Practices using conditionals appropriately yes
Practices iteration appropriately yes
Practices using custom methods appropriately yes
Program validates against input under 2 characters yes
Takes in two inputs and creates a portmanteau yes

Great job overall! I like that you did a really good job of breaking this code up into different methods, it makes it very easy to understand what's going on. Keep up the hard work!

def is_vowel?(letter)
vowels = ["a", "e", "i", "o", "u"]
if vowels.include?(letter)
return true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of include? here. This list of letters might be a good place to use a constant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants