Space - Stephanie #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Apr 2, 2020
| @@ -1,3 +1,3 @@ | |||
| def intersection(list1, list2) | |||
| raise NotImplementedError, "Intersection not implemented" | |||
| intersect = list1 & list2 | |||
There was a problem hiding this comment.
That works as it uses a feature of Ruby. Do think about how you'd solve it with a hash.
| letter_hash = {} | ||
| string.chars.map do |char| | ||
| letter_hash["#{char}"] = string.count(char) |
There was a problem hiding this comment.
string.count(char) is an O(n) operation, so that makes this a total of O(n^2) operation.
It could be better doing this:
Suggested change
| letter_hash["#{char}"] = string.count(char) | |
| letter_hash["#{char}"] = letter_hash["#{char}"].nil? ? 1 : letter_hash["#{char}"] + 1 |
| @@ -1,4 +1,17 @@ | |||
|
|
|||
| def palindrome_permutation?(string) | |||
| return false if string1.length != string2.length | ||
|
|
||
| string1.chars.each do |char| | ||
| if string2.include?(char) |
There was a problem hiding this comment.
.include? is an O(n) operation, making this an O(n^2) method. Can you think of a better way to do this with a hash?
| @@ -1,4 +1,14 @@ | |||
|
|
|||
| def permutations?(string1, string2) | |||
There was a problem hiding this comment.
This fails for heelo and hello, and it's more than a little inefficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.