Liv - Space

lib/max_subarray.rb

@@ -1,8 +1,19 @@
-
-# Time Complexity: ?
-# Space Complexity: ?
+# Time Complexity: on
+# Space Complexity: o1
 def max_sub_array(nums)
     return 0 if nums == nil
+    return nil if nums == []
 
-    raise NotImplementedError, "Method not implemented yet!"
+    max_so_far = nums[0]
+    sum_ending_here = nums[0]
+
+    nums[1..-1].each do |num|
+        sum_ending_here = [sum_ending_here + num, num].max
+
+        if max_so_far < sum_ending_here
+            max_so_far = sum_ending_here
+        end
+    end
+
+    return max_so_far
 end

lib/newman_conway.rb

@@ -1,7 +1,20 @@
+# Time complexity: on
+# Space Complexity: on
+def newman_conway(num)
+  raise ArgumentError if num <= 0
+  starting_array = [0, 1, 1] 
 
+  result = "1"
+  count = 3
 
-# Time complexity: ?
-# Space Complexity: ?
-def newman_conway(num)
-  raise NotImplementedError, "newman_conway isn't implemented"
+  while count <= num
+    starting_array[count] = starting_array[starting_array[count - 1]] + starting_array[count - starting_array[count - 1]]
+    count += 1
+  end
+
+  (2..num).each do |i|
+    result += " #{starting_array[i]}"
+  end
+
+  return result
 end

test/max_sub_array_test.rb

@@ -1,6 +1,6 @@
 require_relative "test_helper"
 
-xdescribe "max subarray" do
+describe "max subarray" do
   it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do
     # Arrange
     input = [-2,1,-3,4,-1,2,1,-5,4]