Skip to content

Time - Yoyo #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
166 changes: 132 additions & 34 deletions lib/linked_list.rb
Original file line number Diff line number Diff line change
@@ -18,71 +18,148 @@ def initialize

# method to add a new node with the specific data value in the linked list
# insert the new node at the beginning of the linked list
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(1)
# Space Complexity: O(1)
def add_first(value)
Comment on lines +21 to 23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError
new_node = Node.new(value)
if @head.nil?
@head = new_node
else
new_node.next = @head
@head = new_node
end
Comment on lines +24 to +30

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simplified as:

Suggested change
new_node = Node.new(value)
if @head.nil?
@head = new_node
else
new_node.next = @head
@head = new_node
end
@head = Node.new(value, @head)

end

# method to find if the linked list contains a node with specified value
# returns true if found, false otherwise
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(1)
# Space Complexity: O(1)
def search(value)
Comment on lines +35 to 37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The time complexity here is O(n)

raise NotImplementedError
if @head.nil?
return false
end
current = @head
until current.data == value || current.next.nil?
current = current.next
end
return current.data == value
end

# method to return the max value in the linked list
# returns the data value and not the node
def find_max
Comment on lines 48 to 50

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError
if @head.nil?
return nil
end
current = @head
max = @head.data
until current.next.nil?
current = current.next
if current.data > max
max = current.data
end
end
return max
end

# method to return the min value in the linked list
# returns the data value and not the node
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(n)
def find_min
Comment on lines +67 to 69

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , but the space complexity is O(1) because you're not making a new list here.

raise NotImplementedError
if @head.nil?
return nil
end
current = @head
min = @head.data
until current.next.nil?
current = current.next
if current.data < min
min = current.data
end
end
return min
end


# method that returns the length of the singly linked list
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def length
Comment on lines +86 to 88

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError
if @head.nil?
return 0
end
count = 1
current = @head
until current.next.nil?
current = current.next
count += 1
end
return count
Comment on lines +89 to +98

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simplified a bit.

Suggested change
if @head.nil?
return 0
end
count = 1
current = @head
until current.next.nil?
current = current.next
count += 1
end
return count
count = 0
current = @head
until current.nil?
current = current.next
count += 1
end
return count

end

# method that returns the value at a given index in the linked list
# index count starts at 0
# returns nil if there are fewer nodes in the linked list than the index value
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def get_at_index(index)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if index >= length?

raise NotImplementedError
if @head.nil?
return nil
end
current = @head
count = 0
until count == index || current.next.nil?
current = current.next
count += 1
end
return current.data
end

# method to print all the values in the linked list
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(n)
def visit
Comment on lines +120 to 122

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , but the space complexity is O(1) because you're not making a new list here.

raise NotImplementedError
if @head.nil?
return nil
end
current = @head
until current.nil?
print current.data
current = current.next
end
end

# method to delete the first node found with specified value
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(n)
def delete(value)
raise NotImplementedError
if @head.nil?
return nil
end
previous = @head
current = @head
until current.data == value || current.nil?
previous = current
current = current.next
end
previous.next == current.next
Comment on lines +137 to +146

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need a check here to see if value is at the head of the list.

Suggested change
if @head.nil?
return nil
end
previous = @head
current = @head
until current.data == value || current.nil?
previous = current
current = current.next
end
previous.next == current.next
if @head.nil?
return nil
elsif @head.data == value
@head = @head.next
return
end
previous = @head
current = @head
until current.data == value || current.nil?
previous = current
current = current.next
end
previous.next == current.next

end

# method to reverse the singly linked list
# note: the nodes should be moved and not just the values in the nodes
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def reverse
Comment on lines +151 to 153

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Looks like you have the right idea, but a missing end

raise NotImplementedError
if @head.nil?
return nil
end
current = @head
until current.nil?
new_previous = current.next
new_current = new_previous.next
new_previous.next = current
current = new_current

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missingend

Suggested change
current = new_current
current = new_current
end

end


@@ -115,25 +192,45 @@ def has_cycle
# Additional Exercises
# returns the value in the first node
# returns nil if the list is empty
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(1)
# Space Complexity: O(1)
def get_first
Comment on lines +195 to 197

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError
if @head.nil?
return nil
else
return @head.data
end
end

# method that inserts a given value as a new last node in the linked list
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def add_last(value)
Comment on lines +206 to 208

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

raise NotImplementedError
new_node = Node.new(value)
if @head.nil?
@head = new_node
else
current = @head
until current.next.nil?
current = current.next
end
current.next = new_node
end
end

# method that returns the value of the last node in the linked list
# returns nil if the linked list is empty
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(1)
# Space Complexity: O(1)
def get_last
Comment on lines +223 to 225

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , but the time complexity is O(n) since you're traveling to the end of the list.

raise NotImplementedError
if @head.nil?
return nil
end
current = @head
while current.next != nil
current = current.next
end
return current.data
end

# method to insert a new node with specific data value, assuming the linked
@@ -158,4 +255,5 @@ def create_cycle

current.next = @head # make the last node link to first node
end
end
end