Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time - Haben #34

Open
wants to merge 81 commits into
base: master
Choose a base branch
from
Open

Time - Haben #34

wants to merge 81 commits into from

Conversation

HabenFoto
Copy link

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a custom model method you wrote. top_ten and spotlight were methods I created to get the top 10 voted works and also it displays the most voted work out of the 3 categories.
Describe how you approached testing that model method. What edge cases did you come up with? Tested validations, relationships, and a customer method test for the spotlight.
What are session and flash? What is the difference between them? Session is a hash that persists between requests while flash stores the data only until the new request, so it gets expired as soon as the request goes to the new request.
What was one thing that you gained more clarity on through this assignment? How useful filters, partials, and fixtures are.
What is the Heroku URL of your deployed application? https://pacific-plains-73626.herokuapp.com/

@beccaelenzil
Copy link

Media Ranker

Functional Requirements: Manual Testing

Criteria yes/no
Before logging in --
1. On index page, there are at most 10 pieces of media on three lists, and a Media Spotlight ✔️
2. Can go into a work's show page ✔️
3. Verify unable to vote on a work, and get a flash message ✔️
4. Can edit this work successfully, and get a flash message ✔️
5. Can go to "View all media" page and see three lists of works, sorted by vote ✔️
6. Verify unable to create a new work when the form is empty, and details about the validation errors are visible to the user through a flash message ✔️
7. Can create a new work successfully. Note the URL for this work's show page ✔️
8. Can delete this work successfully ✔️
9. Going back to the URL of this deleted work's show page produces a 404 or some redirect behavior (and does not try to produce a broken view) This produced a broken view. I'm not entirely sure why offhand as you seem to address a work that is not found in your set_work controller filter.
10. Verify that the "View all users" page lists no users ✔️?
Log in --
11. Logging in with a valid name changes the UI to "Logged in as" and "Logout" buttons ✔️?
12. Your username is listed in "View all users" page ✔️
13. Verify that number of votes determines the Media Spotlight ✔️
14. Voting on several different pieces of media affects the "Votes" tables shown in the work's show page and the user's show page ✔️
15. Voting on the same work twice produces an error and flash message, and there is no extra vote ✔️
Log out --
16. Logging out showed a flash message and changed the UI ✔️
17. Logging in as a new user creates a new user ✔️
18. Logging in as an already existing user has a specific flash message ✔️Thanks for the welcome back :)

Major Learning Goals/Code Review

Criteria yes/no
1. Sees the full development cycle including deployment, and the app is deployed to Heroku ✔️
2. Practices full-stack development and fulfilling story requirements: the styling, look, and feel of the app is similar to the original Media Ranker ✔️
3. Practices git with at least 25 small commits and meaningful commit messages ✔️

Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code

Criteria yes/no
4. Routes file uses resources for works ✔️
5. Routes file shows intention in limiting routes for voting, log-in functionality, and users ✔️
6. The homepage view, all media view, and new works view use semantic HTML ✔️
7. The homepage view, all media view, and new works view use partials when appropriate ✔️
8. The model for media (likely named work.rb) has_many votes ✔️
9. The model for media has methods to describe business logic, specifically for top ten and top media, possibly also for getting works by some category ✔️
10. Some controller, likely the ApplicationController, has a controller filter for finding a logged in user ✔️
11. Some controller, likely the WorksController, has a controller filter for finding a work ✔️
12. The WorksController uses strong params ✔️
13. The WorksController's code style is clean, and focused on working with requests, responses, params, session, flash ✔️

Testing Rails Apps

Criteria yes/no
14. There are valid fixtures files used for users, votes, and works ✔️
15. User model has tests with sections on validations (valid and invalid) and relationships (has votes) ✔️
16. Vote model has tests with sections on validations (valid and invalid) and relationships (belongs to a user, belongs to a vote) ✔️
17. Work model has tests with sections on validations (valid and invalid) and relationships (has votes) ✔️
18. Work model has tests with a section on all business logic methods in the model, including their edge cases You have a few untested methods (Work.books, Work.albums, Work.movies)

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 14+ in Functional Requirements: Manual Testing && 14+ in Code Review ✔️

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Copy link

@beccaelenzil beccaelenzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job overall! Your implementation matches the demo site very closely, and the learning goals for this assignment were definitely met. Controller filters, partial views, flash, session, custom routes, custom model methods -- there's so much good stuff in there! I've left a few in-line comments for you to review. Keep up the hard work!

require "test_helper"

describe WorksController do
let(:work) { works(:one) }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests produced a number of errors. I think to access a variable when using let, you don't use the @ symbol.

Minitest::UnexpectedError:         ActionController::UrlGenerationError: No route matches {:action=>"edit", :controller=>"works", :id=>nil}, missing required keys: [:id]
            test/controllers/works_controller_test.rb:30:in `block (2 levels) in <main>'

it "is invalid if title is nil" do
@work.title = nil
result = @work.valid?
expect(work.category).must_equal "album"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test produced an error. Looks like you're missing an @. Whoops!

Suggested change
expect(work.category).must_equal "album"
expect(@work.category).must_equal "album"

@@ -0,0 +1,16 @@
<section class="top-ten__list-container">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of partial views to DRY up your code.

class Work < ApplicationRecord
has_many :votes
has_many :users, through: :votes
validates :title, presence: true, uniqueness: { scope: :category }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work getting this tricky uniqueness scope figured out!

has_many :users, through: :votes
validates :title, presence: true, uniqueness: { scope: :category }

def self.books

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider whether you could DRY this up with a single method such as get_by_category(category)

vote_4 = Vote.create(user_id: user1, work_id: work3)
end

it "spotlight" do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be specific about what you are testing here. Makes sure it chooses the correct Work. What if two works are tied? This should probably be a separate test of an edge case. What if no works have been voted on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants