Space - Nora #37
Open
Space - Nora #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidamasaki
reviewed
Jun 1, 2020
| @import "**/*"; | ||
|
|
||
| *,*::before,*::after { | ||
| box-sizing: border-box |
There was a problem hiding this comment.
Wow, you strongly prefer border-box sizing, huh?
There was a problem hiding this comment.
Also, even thought the trailing ; is optional on the last entry it's strongly encouraged since it makes reordering and adding new rules easier.
| } | ||
|
|
||
| .user-votes__header { | ||
| color: black |
There was a problem hiding this comment.
Generally speaking one should avoid color names because they can have browser compatibility issues. (black and white don't but it's still generally discouraged.)
Comment on lines
+224
to
+226
| font-size: 2.5rem; | ||
| font-weight: 700; | ||
| margin: 25px auto 40px auto |
| flash[:error] = 'You already voted for this work' | ||
| end | ||
| end | ||
| redirect_back(fallback_location: root_path) |
Comment on lines
+20
to
+24
| @work = Work.find_by(id: params[:id]) | ||
| if @work.nil? | ||
| head :not_found | ||
| return | ||
| end |
There was a problem hiding this comment.
You do this in a number of places. In the future you should DRY things like this up by creating a controller filter.
Comment on lines
+54
to
+59
| <% flash.each do |name, message| %> | ||
| <div class="alert alert-<%= name %>" > | ||
| <span> | ||
| <%= message %> | ||
| </span> | ||
| <% end %> |
Media RankerFunctional Requirements: Manual Testing
Major Learning Goals/Code Review
Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code
Testing Rails Apps
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?