Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space - Jessica #38

Open
wants to merge 79 commits into
base: master
Choose a base branch
from
Open

Space - Jessica #38

wants to merge 79 commits into from

Conversation

seaweeddol
Copy link

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a custom model method you wrote. I wrote a top_ten_works method in the work model to find the ten works with the most votes within a category. I passed it an argument of a category and then used 'where' to find all works within that category. Then I used the join and group methods to combine the Works to their Votes, and ordered the array by count of votes in descending order. Then I returned the first ten elements in the array.
Describe how you approached testing that model method. What edge cases did you come up with? Before implementing the vote counting, I wanted to make sure the method was returning an array of items that were all in the correct category. I also tested that the method returned votes in the correct order. One edge test I implemented was if there were no votes, that the method still returned ten works.
What are session and flash? What is the difference between them? Session persists for the duration of a user's browsing session - when they log in, until they close the browser or log out. Flash persists only through the next redirect.
What was one thing that you gained more clarity on through this assignment? I feel more confident in testing rails methods and controller actions after this assignment. I also gained more clarity on session and flash.
What is the Heroku URL of your deployed application? https://only-cool-media-ranker.herokuapp.com/

@dHelmgren
Copy link

Media Ranker

Functional Requirements: Manual Testing

Criteria yes/no
Before logging in --
1. On index page, there are at most 10 pieces of media on three lists, and a Media Spotlight ✔️
2. Can go into a work's show page ✔️
3. Verify unable to vote on a work, and get a flash message ✔️
4. Can edit this work successfully, and get a flash message ✔️
5. Can go to "View all media" page and see three lists of works, sorted by vote ✔️
6. Verify unable to create a new work when the form is empty, and details about the validation errors are visible to the user through a flash message ✔️
7. Can create a new work successfully. Note the URL for this work's show page ✔️
8. Can delete this work successfully ✔️
9. Going back to the URL of this deleted work's show page produces a 404 or some redirect behavior (and does not try to produce a broken view)
10. Verify that the "View all users" page lists no users ✔️
Log in --
11. Logging in with a valid name changes the UI to "Logged in as" and "Logout" buttons ✔️
12. Your username is listed in "View all users" page ✔️
13. Verify that number of votes determines the Media Spotlight ✔️
14. Voting on several different pieces of media affects the "Votes" tables shown in the work's show page and the user's show page ✔️
15. Voting on the same work twice produces an error and flash message, and there is no extra vote ✔️
Log out --
16. Logging out showed a flash message and changed the UI ✔️
17. Logging in as a new user creates a new user ✔️
18. Logging in as an already existing user has a specific flash message ✔️

Major Learning Goals/Code Review

Criteria yes/no
1. Sees the full development cycle including deployment, and the app is deployed to Heroku ✔️
2. Practices full-stack development and fulfilling story requirements: the styling, look, and feel of the app is similar to the original Media Ranker ✔️
3. Practices git with at least 25 small commits and meaningful commit messages ✔️

Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code

Criteria yes/no
4. Routes file uses resources for works ✔️
5. Routes file shows intention in limiting routes for voting, log-in functionality, and users ✔️
6. The homepage view, all media view, and new works view use semantic HTML ✔️
7. The homepage view, all media view, and new works view use partials when appropriate
8. The model for media (likely named work.rb) has_many votes ✔️
9. The model for media has methods to describe business logic, specifically for top ten and top media, possibly also for getting works by some category ✔️
10. Some controller, likely the ApplicationController, has a controller filter for finding a logged in user
11. Some controller, likely the WorksController, has a controller filter for finding a work ✔️
12. The WorksController uses strong params ✔️
13. The WorksController's code style is clean, and focused on working with requests, responses, params, session, flash ✔️

Testing Rails Apps

Criteria yes/no
14. There are valid fixtures files used for users, votes, and works there are only fixtures for works
15. User model has tests with sections on validations (valid and invalid) and relationships (has votes) ✔️
16. Vote model has tests with sections on validations (valid and invalid) and relationships (belongs to a user, belongs to a vote) ✔️
17. Work model has tests with sections on validations (valid and invalid) and relationships (has votes) ✔️
18. Work model has tests with a section on all business logic methods in the model, including their edge cases ✔️

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 14+ in Functional Requirements: Manual Testing && 14+ in Code Review ✔️
Yellow (Approaches Standards) 12+ in Functional Requirements: Manual Testing && 11+ in Code Review, or the instructor judges that this project needs special attention
Red (Not at Standard) 0-10 in Code Review or 0-11 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Comment on lines +14 to +44
<% Work.top_ten_works("movie").each do |work|%>
<h4>
<%= link_to "#{work.title}", work_path(work.id) %>
<small class="top-ten__creator">by <%= work.creator %></small>
</h4>
<p><%= work.votes.count %> votes</p>
<% end %>
</section>

<section>
<h2 class="top-ten__header">Top Books</h2>
<% Work.top_ten_works("book").each do |work|%>
<h4>
<%= link_to "#{work.title}", work_path(work.id) %>
<small class="top-ten__creator">by <%= work.creator %></small>
</h4>
<p><%= work.votes.count %> votes</p>
<% end %>

</section>

<section>
<h2 class="top-ten__header">Top Albums</h2>
<% Work.top_ten_works("album").each do |work|%>
<h4>
<%= link_to "#{work.title}", work_path(work.id) %>
<small class="top-ten__creator">by <%= work.creator %></small>
</h4>
<p><%= work.votes.count %> votes</p>
<% end %>
</section>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great place to use a view partial for this repeated list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants