forked from AdaGold/media-ranker
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Space - Jessica #38
Open
seaweeddol
wants to merge
79
commits into
Ada-C13:master
Choose a base branch
from
seaweeddol:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Space - Jessica #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing order by votes
Media RankerFunctional Requirements: Manual Testing
Major Learning Goals/Code Review
Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code
Testing Rails Apps
Overall Feedback
|
dHelmgren
reviewed
May 27, 2020
Comment on lines
+14
to
+44
<% Work.top_ten_works("movie").each do |work|%> | ||
<h4> | ||
<%= link_to "#{work.title}", work_path(work.id) %> | ||
<small class="top-ten__creator">by <%= work.creator %></small> | ||
</h4> | ||
<p><%= work.votes.count %> votes</p> | ||
<% end %> | ||
</section> | ||
|
||
<section> | ||
<h2 class="top-ten__header">Top Books</h2> | ||
<% Work.top_ten_works("book").each do |work|%> | ||
<h4> | ||
<%= link_to "#{work.title}", work_path(work.id) %> | ||
<small class="top-ten__creator">by <%= work.creator %></small> | ||
</h4> | ||
<p><%= work.votes.count %> votes</p> | ||
<% end %> | ||
|
||
</section> | ||
|
||
<section> | ||
<h2 class="top-ten__header">Top Albums</h2> | ||
<% Work.top_ten_works("album").each do |work|%> | ||
<h4> | ||
<%= link_to "#{work.title}", work_path(work.id) %> | ||
<small class="top-ten__creator">by <%= work.creator %></small> | ||
</h4> | ||
<p><%= work.votes.count %> votes</p> | ||
<% end %> | ||
</section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great place to use a view partial for this repeated list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
session
andflash
? What is the difference between them?