Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vera - Time #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Vera - Time #26

wants to merge 2 commits into from

Conversation

veralizeth
Copy link

Assignment Submission: Ride Share

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Question Answer
What did your data structure look like at first? Did this structure evolve over time? Why? Yes, my data structure originally only contemplated a hash with trips. Then I changed it to a hash with arrays and hashes inside.
What was your strategy for going through the data structure and gathering information? First I wrote down how my data structure should look like and then I tried to access it with the minimum of data. Just one driver and with one trip, to identify how many loops I should make or the easiest way to access it.
What was an example of something that was necessary to store in a variable? Why was it necessary, useful, or helpful? _total_cost was the variable I created to store the total cost per each driver. It was necessary because without it I would not be able to keep a record per driver of the sum of their trips. Useful to use this value to stored it in a hash or by itself.
What kinds of iteration did you use? Did you use .map? If so, when? If not, why, or when would be a good opportunity to use it? I used .map to iterate over the hash to get the first information, also to iterate over the arrays with the trips. I Used .each_pair to iterate over the hash trips
Were some calculations easier than others? Why? Yes, the first one was easy because I only had to do calculations in one layer, the sum and average ones took me more time to think about the cumulative variable and how to save the key-value pairs.

@jmaddox19
Copy link

Ride Share

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates, reads, and modifies variables ✔️
Correctly creates and accesses arrays ✔️
Correctly creates and accesses hashes ✔️
Reasonably organizes large amounts of related data into nested arrays and hashes ✔️
Correctly iterates through a nested data structure using loops and/or Enumerable methods ✔️
Reasonably organizes small pieces of code into methods, and calls/invokes those methods ✔️

Functional Requirements

Functional Requirement yes/no
To the terminal, the program outputs the correct number of rides each driver has given ✔️
... outputs the total amount of money each driver has made ✔️
... outputs the average rating for each driver ✔️
... outputs which driver made the most money The most money code doesn't seem to be working. It's saying Driver 4 made the most.
... outputs which driver has the highest average rating ✔️

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 2-3 in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0,1 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise ✅ Great job making use of enumerable methods!!!
Logical/Organized ✅ Great job breaking the code into small methods!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants