Time - Sharon

[sharonkeikei]

Assignment Submission: Ride Share

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Question	Answer
What did your data structure look like at first? Did this structure evolve over time? Why?	It looked the same, I took my time to figure out the data structure before I started since I know that's the most important part.
What was your strategy for going through the data structure and gathering information?	I tried to simplify the steps as much as possible, my codes were super long in the beginning.
What was an example of something that was necessary to store in a variable? Why was it necessary, useful, or helpful?	I stored the variables for highest rating and most earning to compare with the next one and decide to replace it or not to get the driver that has highest average rating or the driver that has the most earning.
What kinds of iteration did you use? Did you use .map? If so, when? If not, why, or when would be a good opportunity to use it?	I didn't use .map since I would like to use one loop to put all the info into the terminal but I think it would be great to use it for comparison of highest rating and most earning.
Were some calculations easier than others? Why?	The first question was the simplest, since it only need to loop thru the hash to get the data.

[jmaddox19]

Ride Share

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Correctly creates, reads, and modifies variables	✔️
Correctly creates and accesses arrays	✔️
Correctly creates and accesses hashes	✔️
Reasonably organizes large amounts of related data into nested arrays and hashes	✔️
Correctly iterates through a nested data structure using loops and/or Enumerable methods	✔️
Reasonably organizes small pieces of code into methods, and calls/invokes those methods	✔️

Functional Requirements

Functional Requirement	yes/no
To the terminal, the program outputs the correct number of rides each driver has given	✔️
... outputs the total amount of money each driver has made	✔️
... outputs the average rating for each driver	✔️
... outputs which driver made the most money	✔️
... outputs which driver has the highest average rating	✔️

Overall Feedback

Great work!

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	4+ in Code Review && 3+ in Functional Requirements	✔️
Yellow (Approaches Standards)	2-3 in Code Review && 2+ in Functional Requirements
Red (Not at Standard)	0,1 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	One indentation note: In ruby engineers typically indent with 2 spaces rather than 1
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized	Great job making a couple small methods! As we work more with methods, it will become more comfortable to put more of the code into small methods.