Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Haben-Ride-share.rb #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

HabenFoto
Copy link

Assignment Submission: Ride Share

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Question Answer
What did your data structure look like at first? Did this structure evolve over time? Why? I tried 2 different structures but then picked one that worked well in accessing the data from within.
What was your strategy for going through the data structure and gathering information? Using the .each method twice two inorder to access the array with the variable name Rideshare and then another .each to get the data from the hash.
What was an example of something that was necessary to store in a variable? Why was it necessary, useful, or helpful? In Q.3, the sum of all the ratings was necessary to store it in a variable called sum in order to get the average rating for each driver by dividing it by the number of trips each driver made.
What kinds of iteration did you use? Did you use .map? If so, when? If not, why, or when would be a good opportunity to use it? .each and .map . I used .each in order to get the number of rides, total money earned and the average rating for each driver. I used it because it was easier to access the layers of structure (arrays and hashes). I used the .map method to find the driver who made the most money.
Were some calculations easier than others? Why? Yes. It was easier to calculate the number of rides that each driver made than finding who made the most money.

@kaidamasaki
Copy link

Ride Share

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates, reads, and modifies variables ✔️
Correctly creates and accesses arrays ✔️
Correctly creates and accesses hashes ✔️
Reasonably organizes large amounts of related data into nested arrays and hashes ✔️
Correctly iterates through a nested data structure using loops and/or Enumerable methods ✔️
Reasonably organizes small pieces of code into methods, and calls/invokes those methods ✔️

Functional Requirements

Functional Requirement yes/no
To the terminal, the program outputs the correct number of rides each driver has given ✔️
... outputs the total amount of money each driver has made ✔️
... outputs the average rating for each driver ✔️
... outputs which driver made the most money ✔️
... outputs which driver has the highest average rating ✔️

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 2-3 in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0,1 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation Your indentation could use some work. In some places you only indented with one space and in a few ohters you forgot to indent.
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants