-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Space - Katie #39
base: master
Are you sure you want to change the base?
Space - Katie #39
Conversation
Ride ShareMajor Learning Goals/Code Review
Functional Requirements
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
end | ||
|
||
# ride information copied from the rides.csv file, organized as an array of hashes, where each hash represents one ride | ||
rides = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this structure!
@@ -0,0 +1,138 @@ | |||
# a method to add a driver to the driver hash | |||
def add_driver_to_hash(ride_hash, drivers_hash) | |||
drivers_hash[ride_hash[:driver_id]] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So any driver you add this this won't have any rides listed, but will have a cost and total of ratings?
# initiliaze the new drivers hash where information per driver will be stored | ||
drivers = {} | ||
|
||
# loop through the rides array of hashes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these segments could be broken into methods.
Assignment Submission: Ride Share
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
.map
? If so, when? If not, why, or when would be a good opportunity to use it?