Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mona #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Mona #12

wants to merge 2 commits into from

Conversation

MonaRahmani
Copy link

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Mona, you hit the learning goals here. Well done.

# Space Complexity: ?
# Time Complexity: o(n)
# Space Complexity: o(1)

def max_sub_array(nums)
return 0 if nums == nil

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return 0 if nums == nil
return 0 if nums == nil
return nil if nums.length == 0

Comment on lines +3 to 5
# Time complexity: 0(n)
# Space Complexity: 0(n)
def newman_conway(num)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants