Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rachael --Final Water Showdown #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions lib/max_subarray.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,21 @@

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n)
# Space Complexity: O(1)
def max_sub_array(nums)
return 0 if nums == nil

raise NotImplementedError, "Method not implemented yet!"
if nums.empty?
return nil
end
max_so_far = nums[0]
max_ending_here = 0

nums.each do |num|
max_ending_here += num
if max_so_far < max_ending_here
max_so_far = max_ending_here
elsif max_ending_here < 0
max_ending_here = 0
end

end
return max_so_far
end
23 changes: 22 additions & 1 deletion lib/newman_conway.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,26 @@
# Time complexity: ?
# Space Complexity: ?
def newman_conway(num)
raise NotImplementedError, "newman_conway isn't implemented"
if num == 0
raise ArgumentError
end
if num == 1
return "1"
end

array = []
array[0] = 0
array[1] = 1
array[2] = 1

i = 3

while i <= num
array[i] = array[array[i-1]] + array[i - array[i - 1]]
i += 1
end

array.slice!(0)

return array.join(',').gsub(',', ' ')
end
2 changes: 1 addition & 1 deletion test/max_sub_array_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative "test_helper"

xdescribe "max subarray" do
describe "max subarray" do
it "will work for [-2,1,-3,4,-1,2,1,-5,4]" do
# Arrange
input = [-2,1,-3,4,-1,2,1,-5,4]
Expand Down