- FIRE - Stacy's Exquisite #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot a function ???
CheezItMan
reviewed
Jan 17, 2021
| } | ||
|
|
||
| PlayerSubmissionForm.propTypes = { | ||
| index: PropTypes.number.isRequired, | ||
| sendSubmission: PropTypes.func.isRequired, | ||
| isSubmitted: PropTypes.bool.isRequired, |
There was a problem hiding this comment.
Just a note, that because you've added this prop the tests are giving a warning because the tests aren't using. If you add that prop to the tests, the warning will stop.
Comment on lines
18
to
+19
| submission: PropTypes.string.isRequired, | ||
| isSubmitted: PropTypes.bool.isRequired, |
There was a problem hiding this comment.
Also if you're not using submission as a prop, you should change it. You're getting a warning because this is required, but you're not using it.
| @@ -22,14 +49,14 @@ const Game = () => { | |||
| <p>Please follow the following format for your poetry submission:</p> | |||
|
|
|||
| <p className="Game__format-example"> | |||
| { exampleFormat } | |||
| { stringFormat } | |||
There was a problem hiding this comment.
stringFormat is a function here, so you can't render it. I'm not sure what this is supposed to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Exquisite React
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection