Earth/Taylor #32
Open
Earth/Taylor #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Dec 18, 2020
Comment on lines
+10
to
12
| # Time complexity - O(1) - I think these first two would be O(1) because they dont need to traverse the list, while the other 4 do so I assumed O(n) for those | ||
| # Space complexity - O(1) | ||
| def add_first(data) |
Comment on lines
+17
to
19
| # Time complexity - O(1) | ||
| # Space complexity - O(1) | ||
| def get_first |
Comment on lines
+27
to
29
| # Time complexity - O(n) | ||
| # Space complexity - O(n) - I had some trouble determining space complexity of linked lists methods, I ended up assuming they were probably the same as time complexity. I made this assumption based on the call stack of operations, let me know if I'm off base or misunderstanding | ||
| def length |
There was a problem hiding this comment.
👍 However the space complexity is O(1) since you're not creating any new lists.
Comment on lines
+39
to
41
| # Time complexity - O(n) | ||
| # Space complexity - O(n) | ||
| def add_last(data) |
There was a problem hiding this comment.
👍 , however the space complexity is O(1)
Comment on lines
+55
to
57
| # Time complexity - O(n) | ||
| # Space complexity - O(n) | ||
| def get_last |
There was a problem hiding this comment.
👍 , however the space complexity is O(1)
Comment on lines
+70
to
72
| # Time complexity - O(n) | ||
| # Space complexity - O(n) | ||
| def get_at_index(index) |
There was a problem hiding this comment.
👍 , however the space complexity is O(1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked List Comprehension Questions