-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrays-assignment #30
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ida, you hit some of the learning goals and struggled in some other areas. Take a look at my suggestions and let me know what questions you have. In particular, I'd like you to review binary search.
# Time complexity: ? | ||
# Space complexity: ? | ||
def length(array) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
# Time complexity: ? | ||
# Space complexity: ? | ||
def print_array(array) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
||
# Finds and returns the largest integer value the array | ||
# Assumes that the array is not sorted. | ||
# Time complexity: ? | ||
# Space complexity: ? | ||
def find_largest(array, length) | ||
raise NotImplementedError | ||
def find_largest(array, _length) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
end | ||
|
||
# Finds and returns the smallest integer value in the array | ||
# Assumes that the array is not sorted. | ||
# Time complexity: ? | ||
# Space complexity: ? | ||
def find_smallest(array, length) | ||
raise NotImplementedError | ||
def find_smallest(array, _length) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
i = i + 1 | ||
end | ||
return smallest | ||
|
||
end | ||
|
||
# Reverses the values in the integer array in place | ||
# Time complexity: ? | ||
# Space complexity: ? | ||
def reverse(array, length) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
i = i + 1 | ||
max = max - 1 | ||
end | ||
return array | ||
end | ||
|
||
# For an array sorted in ascending order, searches for 'value_to_find'. | ||
# Returns true if found, false otherwise. | ||
# Time complexity: ? | ||
# Space complexity: ? | ||
def binary_search(array, length, value_to_find) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Chris M <chris@adadevelopersacademy.org>
Co-authored-by: Chris M <chris@adadevelopersacademy.org>
Co-authored-by: Chris M <chris@adadevelopersacademy.org>
No description provided.