Earth - Ringo #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Apr 7, 2021
Comment on lines
+15
to
19
| // Time Complexity: O(log n) -- assuming the tree is balanced, as the number of nodes increases | ||
| // the number of times addHelper has to be called will only increase logarithmically | ||
| // Space Complexity: O(log n) -- assuming the tree is balanced, the number of calls to addHelper | ||
| // that will be on the stack at one time increases logarithmically, rather than linearly | ||
| add(key, value) { |
There was a problem hiding this comment.
👍 Correct on complexity, with the assumption
Comment on lines
+45
to
49
| // Time Complexity: O(log n) -- assuming the tree is balanced, as tree increases in size, | ||
| // the number of times findHelper has to be called will only increase logarithmically | ||
| // Space Complexity: O(log n) -- assuming the tree is balanced, the number of calls to findHelper | ||
| // on the stack at one time increases logarithmically | ||
| find(key) { |
There was a problem hiding this comment.
👍 Correct on complexity, with the assumption
Comment on lines
+65
to
68
| // Time Complexity: O(n). Method needs to visit every node in the tree | ||
| // Space Complexity: O(log n). The number of function calls on the stack will only be as great | ||
| // as the maximum height of the tree, which increases logarithmically to # of nodes (assuming balanced) | ||
| inorder() { |
There was a problem hiding this comment.
👍 Correct on complexity, with the assumption
Comment on lines
+81
to
84
| // Time Complexity: O(n). Method needs to visit every node in the tree | ||
| // Space Complexity: O(log n). The number of function calls on the stack will only be as great | ||
| // as the maximum height of the tree, which increases logarithmically to # of nodes (assuming balanced) | ||
| preorder() { |
There was a problem hiding this comment.
👍 Correct on complexity, with the assumption
Comment on lines
+97
to
100
| // Time Complexity: O(n). Method needs to visit every node in the tree | ||
| // Space Complexity: O(log n). The number of function calls on the stack will only be as great | ||
| // as the maximum height of the tree, which increases logarithmically to # of nodes (assuming balanced) | ||
| postorder() { |
There was a problem hiding this comment.
👍 Correct on complexity, with the assumption
Comment on lines
+113
to
118
| // Time Complexity: O(n). Method needs to follow every branch to its end | ||
| // and therefore visits every node. | ||
| // Space Complexity: O(log n). The max number of function calls on the stack will | ||
| // only be the maximum height of the tree, which scales logarithmically to the | ||
| // size of the tree (if balanced) | ||
| height() { |
There was a problem hiding this comment.
👍 Correct on complexity, with the assumption
Comment on lines
+135
to
139
| // Time Complexity: O(n). The method needs to visit every node in the tree so the time taken | ||
| // will increase linear to the size of the tree increasing. | ||
| // Space Complexity: O(n). The size of the queue at any point in time will increase logarithmically | ||
| // with the size of the tree, but the results array will increase linear to the size of the tree. | ||
| bfs() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.