Cheetahs - Ev #129

evelynburrito · 2022-11-12T23:37:15Z

No description provided.

…ute to pass tests

nancy-harris

Excellent job! Your code overall is great! There are a few comments below on ways to make the code easier to read, but otherwise you did a great job!

nancy-harris · 2022-12-02T17:15:25Z

app/models/task.py

@@ -2,4 +2,29 @@


 class Task(db.Model):


nancy-harris · 2022-12-02T17:21:33Z

app/routes.py

+tasks_bp = Blueprint("tasks", __name__, url_prefix="/tasks")
+
+@tasks_bp.route("", methods=["POST", "GET"])


It would be a good idea to separate "POST" and "GET". Putting them together makes the function really long and harder to read since everything is indented an extra level because of the if statement to distinguish between POST and GET.

nancy-harris · 2022-12-02T17:30:22Z

app/routes.py

+        sort_by_query = request.args.get('sort')
+
+        tasks = Task.query.all()


It would be a good idea to have this as the else that comes at the end of the if statement that starts on line 33. The way it's done now, all of the tasks are pulled twice if there's a sort to do.

nancy-harris · 2022-12-02T18:41:43Z

app/routes.py

+
+        try:
+            task = Task(title = request_body['title'], description = request_body['description'])
+        except KeyError:
+            invalid_dict = {"details": "Invalid data"}
+            return make_response(jsonify(invalid_dict),400)
+
+        db.session.add(task)
+        db.session.commit()
+
+        response_body = {"task": task.to_dict()}
+
+        return make_response(jsonify(response_body), 201)


nancy-harris · 2022-12-02T18:43:20Z

app/routes.py

+        return make_response({"details": f'Task {task.task_id} ' f'"{task.title}"' ' successfully deleted'}, 200)
+
+def validate_model_id(cls,task_id):


Yay, helper function!

nancy-harris · 2022-12-02T19:17:42Z

tests/test_wave_01.py

 def test_get_task_not_found(client):
    # Act
    response = client.get("/tasks/1")
    response_body = response.get_json()

    # Assert
    assert response.status_code == 404
-
-    raise Exception("Complete test with assertion about response body")
+    assert response_body == {"message":"Task 1 not found"}


nancy-harris · 2022-12-02T19:18:23Z

tests/test_wave_01.py

@@ -131,13 +130,13 @@ def test_update_task_not_found(client):
    # Assert
    assert response.status_code == 404

-    raise Exception("Complete test with assertion about response body")
-    # *****************************************************************
+    assert response_body == {"message":"Task 1 not found"}


nancy-harris · 2022-12-02T19:18:51Z

tests/test_wave_01.py

@@ -161,15 +160,15 @@ def test_delete_task_not_found(client):
    # Assert
    assert response.status_code == 404

-    raise Exception("Complete test with assertion about response body")
+    assert response_body == {"message":"Task 1 not found"}


nancy-harris · 2022-12-02T19:22:15Z

tests/test_wave_03.py

@@ -128,13 +128,13 @@ def test_mark_complete_missing_task(client):
    # Assert
    assert response.status_code == 404

-    raise Exception("Complete test with assertion about response body")
+    assert response_body == {"message": "Task 1 not found"}


nancy-harris · 2022-12-02T19:22:37Z

tests/test_wave_03.py

@@ -143,7 +143,7 @@ def test_mark_incomplete_missing_task(client):
    # Assert
    assert response.status_code == 404

-    raise Exception("Complete test with assertion about response body")
+    assert response_body == {"message": "Task 1 not found"}


evelynburrito added 8 commits November 6, 2022 21:07

made get and post routes

40fa594

added get one task route

6387aa5

made put route

1cba073

mostly done with wave one. fixed sytax and response body in delete ro…

df18080

…ute to pass tests

fixed syntax in post route to pass test

fff0f2b

no new changes. Passes all Wave 1 tests

85f79ba

made asc and desc query params. Passes all Wave 2 tests.

ce7bc09

added mark_complete and mark_incomplete routes. Passes all Wave 3 tests

af1f427

nancy-harris reviewed Dec 2, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cheetahs - Ev #129

Cheetahs - Ev #129

evelynburrito commented Nov 12, 2022

nancy-harris left a comment

nancy-harris Dec 2, 2022

nancy-harris Dec 2, 2022

nancy-harris Dec 2, 2022

nancy-harris Dec 2, 2022

nancy-harris Dec 2, 2022

nancy-harris Dec 2, 2022

nancy-harris Dec 2, 2022

nancy-harris Dec 2, 2022

nancy-harris Dec 2, 2022

nancy-harris Dec 2, 2022

		tasks_bp = Blueprint("tasks", __name__, url_prefix="/tasks")

		@tasks_bp.route("", methods=["POST", "GET"])

		sort_by_query = request.args.get('sort')

		tasks = Task.query.all()

		return make_response({"details": f'Task {task.task_id} ' f'"{task.title}"' ' successfully deleted'}, 200)

		def validate_model_id(cls,task_id):

Cheetahs - Ev #129

Are you sure you want to change the base?

Cheetahs - Ev #129

Conversation

evelynburrito commented Nov 12, 2022

nancy-harris left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment