Kunzite - Gabby Y, Amber S, Areeg J, Angelica Y #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnyoung
changed the title
anselrognlie
reviewed
Aug 1, 2023
|
|
||
| return make_response(jsonify("All cards successfully deleted!"), 200) | ||
|
|
||
| @cards_bp.route("/<card_id>", methods=["PATCH"]) |
There was a problem hiding this comment.
Since this isn't a general purpose PATCH method, consider adding an additional qualifier to the end (like the mark (in)complete endpoints in task list)
@cards_bp.route("/<card_id>/like", methods=["PATCH"])
Comment on lines
+8
to
+9
| @cards_bp.route("", methods=["POST"]) | ||
| def create_card(): |
There was a problem hiding this comment.
👀 We shouldn't be able to create a Card that doesn't belong to a Board. Consider using the nested POST under Board to create a new Card which belongs to that Board, rather than associating an existing Card to an existing Board. That approach was slightly peculiar to Task List, which allowed Tasks to exist that weren't part of an overarching Goal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.