chatlog, am I talking to myself? #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+18
to
+25
| const countLikes = () => { | ||
| let heartCount = 0; | ||
| for (let message of messages) { | ||
| if (message.liked) { | ||
| heartCount += 1; | ||
| } | ||
| }return heartCount; | ||
| }; |
There was a problem hiding this comment.
Great use of the chat data to calculate the total hearts! Another way we could do this is with the Array.reduce function:
let initialValue = 0;
return messages.reduce((total, message) => {
return (chat.liked === true) ? total + 1 : total;
}, initialValue);| return ( | ||
| <div id="App"> | ||
| <header> | ||
| <h1>Application title</h1> | ||
| <h1>Waiting for Chat GDT</h1> |
Comment on lines
+11
to
+17
| const localOrRemote = (sender) => { | ||
| if (sender === 'Vladimir') { | ||
| return 'chat-entry local'; | ||
| } else if (sender === 'Estragon') { | ||
| return 'chat-entry remote'; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Small style note: the indentation got a little messed up here, this is something we might add to a checklist of things to review our code for before opening PRs.
Comment on lines
+11
to
+19
| const localOrRemote = (sender) => { | ||
| if (sender === 'Vladimir') { | ||
| return 'chat-entry local'; | ||
| } else if (sender === 'Estragon') { | ||
| return 'chat-entry remote'; | ||
| }; | ||
| }; | ||
| return ( | ||
| <div className="chat-entry local"> | ||
| <h2 className="entry-name">Replace with name of sender</h2> | ||
| <div className= {localOrRemote(sender)}> |
There was a problem hiding this comment.
We could simplify this a little and remove the duplication of the chat-entry class name if we use an interpolated string for the class on line 19:
const localOrRemote = (sender) => {
return (sender === 'Vladimir') ? 'local' : 'remote';
};
return (
{`chat-entry ${chatLocal}`}
<div className= {`chat-entry ${localOrRemote(sender)}`}>
...|
|
||
| Chatlog.propTypes = { | ||
| entries: PropTypes.arrayOf ( | ||
| PropTypes.shape ( |
There was a problem hiding this comment.
Nice use of PropTypes.shape for more detail on what data is expected for this component =]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.