Complete! #66
Complete! #66
Conversation
Co-authored-by: Valerie Valentin <valerie-valentine@users.noreply.github.com>
| if title and genre and rating: | ||
| return {"title": title, "genre": genre, "rating": rating} | ||
| else: | ||
| return None |
There was a problem hiding this comment.
I like the way you did this! It's nice, easy and elegant! My one small suggestion would be what we've mentioned in class which is if you have a guard clause like what is on lines 5-6, you don't need an else statement. It's just a small change, but one less line of code is one less line of code we may have to debug!
|
|
||
| def add_to_watchlist(user_data, movie): | ||
| user_data["watchlist"].append(movie) | ||
| return user_data |
| if title == item['title']: | ||
| watched_movie.append(item) | ||
| movie_to_watchlist.remove(item) | ||
| return user_data |
There was a problem hiding this comment.
Because we do want the user_data to be changed as we add and remove movies from one list to the other, making two new variables to hold each individual list on lines 20-21 isn't absolutely necessary! We could just as easily replace "movie_to_watchlist" on line 23 with "user_data['watchlist']" and "watched_movie" on line 25 with "user_data['watched']". If it's easier for you to separate the lists out into their own variables however, that is totally fine and feel free to ignore my comment!
| total_ratings = 0 | ||
| number_movies = len(user_data["watched"]) | ||
|
|
||
| if len(user_data["watched"]) == 0: |
There was a problem hiding this comment.
Great job using a guard clause that can help us avoid a Zero Division Error later on! We could also include a compound conditional here to make sure there is a user_data["watched"] list to begin with!
| if len(user_data["watched"]) == 0: | ||
| return 0.0 | ||
|
|
||
| for i in range(len(user_data["watched"])): |
There was a problem hiding this comment.
Don't forget you have a variable that already holds "len(user_data["watched"])!
| for movie in unique_watch: | ||
| if movie not in no_duplicate_unique_watch: | ||
| no_duplicate_unique_watch.append(movie) | ||
| return no_duplicate_unique_watch |
There was a problem hiding this comment.
I like where you've started here! My challenge to you would be to see if there is a way you could completely remove that second loop on lines 85-87! Think about a compound conditional in an earlier part of the code! And watch those for loops!
| # ----------------------------------------- | ||
| # ------------- WAVE 4 -------------------- | ||
| # ----------------------------------------- | ||
|
|
||
| def get_available_recs(user_data): | ||
| available_recs = [] | ||
| friends_movies_recs = get_friends_unique_watched(user_data) |
| for i in range(len(friends_movies_recs)): | ||
| if friends_movies_recs[i]["host"] in user_data["subscriptions"]: | ||
| available_recs.append(friends_movies_recs[i]) | ||
| return available_recs |
There was a problem hiding this comment.
Just keep watching out for those loops, but this looks good otherwise!
| def get_new_rec_by_genre(user_data): | ||
| available_recs = [] | ||
| friends_movies_recs = get_friends_unique_watched(user_data) | ||
| user_fav_genre = get_most_watched_genre(user_data) |
| for i in range(len(user_data["favorites"])): | ||
| if user_data["favorites"][i] in users_watchlist: | ||
| available_recs.append(user_data["favorites"][i]) | ||
| return available_recs |
There was a problem hiding this comment.
Same thing I've been saying before for each of these last two functions as well about the for loops, but other than that, you used helper functions really well!
Ready for thy feedback!