Ruby Kimberly & Sage #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llowing elements: header, temp section, sky section, city name section, and weather garden section.
Temp section
…nction. Landscape changes as temp is changed by user.
…lso updated in the header at the top of the page. Added event listeners for the reset button, wave 3 completed
…urrent temperature of specified city
…own and displays different sky settings. Also added event listener for this change
Sky section
| <script src="./src/index.js"></script> | ||
| <header class="header__header"> | ||
| <h1>Weather Report</h1> | ||
| <span>Follow your curio-city: |
| temp: 70, | ||
| }; | ||
|
|
||
| const convertKToF = (temp) => { |
| formatTempAndGarden(); | ||
| }) | ||
| .catch((error) => { | ||
| console.log('Could not retrieve the weather:') |
There was a problem hiding this comment.
Minor nitpick, but it seems you meant to include printing the error, but didn't!
| getWeather(); | ||
| }) | ||
| .catch((error) => { | ||
| console.log('Could not find latitute and longitude:', error.response); |
There was a problem hiding this comment.
I believe errors don't have a response, you would just print the error directly.
| }); | ||
| }; | ||
|
|
||
| const getCoordinates = async () => { |
There was a problem hiding this comment.
Generally, if you add async to the function definition, that means you are using await instead of .then(). Since you're using .then(), you do not need the async here.
| gardenContent.classList = `garden__content ${skyColor}`; | ||
| } | ||
|
|
||
| const formatTempAndGarden = () => { |
| newLandscape.textContent = landscape; | ||
| }; | ||
|
|
||
| const increaseTemp = () => { |
| formatTempAndGarden(); | ||
| }; | ||
|
|
||
| const decreaseTemp = () => { |
| const decreaseTempBtn = document.getElementById('decreaseTempBtn'); | ||
| decreaseTempBtn.addEventListener('click', decreaseTemp); | ||
|
|
||
| updateCityName(); |
There was a problem hiding this comment.
This function call is not necessary when the page first loads since it's the one that needs to be called when users are typing something in to the search bar.
| formatTempAndGarden(); | ||
| }; | ||
|
|
||
| const registerEventHandlers = () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.