Sphinx_Olga_Karaivanska #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikellewade
reviewed
Jan 4, 2025
Comment on lines
+7
to
+8
| const senders = Array.from(new Set(initialMessages.map(initialMessage => initialMessage.sender))); | ||
| const chatHeader = `Chat between ${senders.join(' and ')}`; |
There was a problem hiding this comment.
Nice, very concise yet still readable!
Comment on lines
+12
to
+20
| const toggleLike = (id) => { | ||
| setMessages((prevMessages) => | ||
| prevMessages.map((message) => | ||
| message.id === id | ||
| ? { ...message, liked: !message.liked } | ||
| : message | ||
| ) | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Nice work on this function! By passing this down to your individual chat messages you are now able to have a single source of truth!
Comment on lines
+22
to
+24
| const getTotalLikes = () => { | ||
| return messages.filter((message) => message.liked).length; | ||
| }; |
There was a problem hiding this comment.
You could also do this with the reduce method like so:
const totalLikes = chatMessages.reduce((count, message) => count + (message.liked ? 1 : 0), 0);| </header> | ||
| <main> | ||
| {/* Wave 01: Render one ChatEntry component | ||
| Wave 02: Render ChatLog component */} | ||
| <ChatLog entries={messages} toggleLike={toggleLike} /> |
|
|
||
| const ChatEntry = () => { | ||
| const ChatEntry = ({ sender, body, timeStamp, liked, onLikeToggle, type }) => { |
Comment on lines
+13
to
+16
| sender={entry.sender} | ||
| body={entry.body} | ||
| timeStamp={entry.timeStamp} | ||
| liked={entry.liked} |
There was a problem hiding this comment.
Since the names of the keys on entry are the same as the names your are setting on ChatEntry attributes/you are using all of the values in entry you could do something something like this to save you a few keystrokes:
const chatComponents = entries.map((entry) => {
return(
<ChatEntry
{...entry}
onLikeToggle={onLikeBtnToggle}
key={entry.id}
/>
);
});
Comment on lines
+26
to
+35
| entries: PropTypes.arrayOf( | ||
| PropTypes.shape({ | ||
| id: PropTypes.number.isRequired, | ||
| sender: PropTypes.string.isRequired, | ||
| body: PropTypes.string.isRequired, | ||
| timeStamp: PropTypes.string.isRequired, | ||
| liked: PropTypes.bool.isRequired, | ||
| }) | ||
| ).isRequired, | ||
| toggleLike: PropTypes.func.isRequired, |
| @@ -4,188 +4,215 @@ | |||
| "sender":"Vladimir", | |||
| "body":"why are you arguing with me", | |||
| "timeStamp":"2018-05-29T22:49:06+00:00", | |||
| "liked": false | |||
| "liked": false, | |||
| "likeCount": 0 | |||
There was a problem hiding this comment.
Seems like you decided not to use the likeCount since you noticed that we could just use liked instead.
Comment on lines
+10
to
+16
| <p>{body}</p> | ||
| <p className="entry-time"> | ||
| <TimeStamp time={timeStamp} /> | ||
| </p> | ||
| <button className="like" onClick={onLikeToggle}> | ||
| {liked ? '❤️' : '🤍'} | ||
| </button> |
Comment on lines
+23
to
+27
| sender: PropTypes.string.isRequired, | ||
| body: PropTypes.string.isRequired, | ||
| timeStamp: PropTypes.string.isRequired, | ||
| liked: PropTypes.bool.isRequired, | ||
| onLikeToggle: PropTypes.func.isRequired, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.