Currency validation: Addressing bug found by @ellevargas #27

Trishthedish · 2016-10-28T06:27:40Z

After spending lots of time testing out theories about how I could solve the rounding issue.

Some found here: https://repl.it/EI4h/3
I looked at where the issue was occurring, and how many times it was actually being triggered. I yelped, with joy 🌈 to realize it was only happening 7 times throughout the site.

Found a clever way to achieve MVP by simply removing the offensive data.

I totally realize this is mvp territory && highlighted a gap in my understanding of how to use BigDecimal properly in Ruby.

@Hamled any resources you might recommend on actually solving this problem in a non-hack-mvp type of way?

Also, its late & if this no sense. I can explain tomorrow

…th div tags around it, will download other pics and update products csv

… separated images into folders in assets by category

…ow pages looking real nice. I will fix any conflicts in the morning after I submit pr

…wn authentication -- both create and destroy methods

…tion method

…th sessions resources except for login and logout routes - session new and destroy

Ev styling

…y github

… status, and ship and fulfillment button. Except order details associated with this order item

…the products in the seed csv

…der item

…ed this.

Ev accessibility edits

[MW] seller manage panel Completed!

created a formalized and fun readme

had deleted this because it broke tests. can fix that. need this. …

alt_text now works sorry guys

Mw css sytax fix

ellevargas and others added 30 commits October 20, 2016 19:56

did rake db migrate after pulling from master

ec674e1

made it so the word Vampazon is the link to the homepage

dbaf3b7

added pajamas image to assets and got it working, updated products wi…

49ea1b1

…th div tags around it, will download other pics and update products csv

added images for Minions except for gif, which I will test later, and…

b72150b

… separated images into folders in assets by category

all images except logo working and sized within ratio, all product sh…

62d4681

…ow pages looking real nice. I will fix any conflicts in the morning after I submit pr

added gems simple_form and bcrypt

71f2fe2

added helper method current_user

8a7e354

commented out github authentication method, replaced with roll-your-o…

c2697fa

…wn authentication -- both create and destroy methods

replaced new and create methods with roll-your-own-auth methods

2d13c66

added has_secure_password validation, commented out github authentica…

eb978b3

…tion method

added partial 'navigation_links'

9df7f91

added user login form

1827b82

added user registration form

42124e6

replaced user routes with user resources, replaced sessions routes wi…

d1c228e

…th sessions resources except for login and logout routes - session new and destroy

auth from scratch w password digest nav links

1f66e50

commented out scratch authentication

f715ebc

commented out auth by scratch, uncommented github auth

25330ea

added link to github auth

9d6d6d5

uncommented the git sessions routes

e203d4a

Merge pull request #21 from mayawang/ev_styling

eaa92b0

Ev styling

changed auth_hash['id'] to auth_hash['uid'] and the like

daad4ac

commented out most methods

d8aca65

fixed typos

18b09ae

fixed typos

f1af9c7

fixed typos, fixed through to join table

1837152

fixed typos

4a53879

commented out has_secure_password, uncommented validators and build b…

687a305

…y github

moved and commented out create test

f13c901

added true test, added options for other controller tests

8a90d51

fixed odd rails references _id_id thing

396ebc0

Trishthedish and others added 30 commits October 26, 2016 23:04

Started to create readme

956a563

completed mvp logic for seller management show order items details by…

4f5214c

… status, and ship and fulfillment button. Except order details associated with this order item

made the vampazon logo image and added alt text to every last one of …

72b8810

…the products in the seed csv

completed mvc logic for link to order details associated with this or…

90feb46

…der item

Merge remote-tracking branch 'origin' into mw_seller_manage_account

5047b0d

Update README.md

a5ee634

had deleted this because it broke tests. can fix that. need this. fix…

9af9412

…ed this.

fixed color on text on logo image

84944cb

Merge pull request #57 from mayawang/ev_accessible

972154c

Ev accessibility edits

resolved merge conflict

56899a1

Merge pull request #58 from mayawang/mw_seller_manage_account

b10f834

[MW] seller manage panel Completed!

Merge pull request #59 from mayawang/readme

74c6b59

created a formalized and fun readme

Merge pull request #60 from mayawang/sk-undo-show-page-seller

f8df9ac

had deleted this because it broke tests. can fix that. need this. …

rake db migrate

3d05c05

alt_text now works yay

019443a

Merge pull request #61 from mayawang/ev_oopsiwasonmaster

0a57cd7

alt_text now works sorry guys

fixed sytax error in app.css

9207636

resolved merge conflict

6aa4457

Merge pull request #62 from mayawang/mw_css_sytax_fix

f7710b2

Mw css sytax fix

Updated Gemfile for heroku

1e74b1d

comment out line 10 of application.rb

c8d1d90

missing css syntax

754a46b

fix syntax in application.css

b8cb297

Remove integer limits for postgres

981b6ba

Convert types in seeds

cf0d013

Change phone columns to string

02a5d0e

Remove unused script tags

d5ddbf5

Merge branch 'master' of github.com:mayawang/Vampazon

b2f7615

no more integer limit 4 bs

269307e

Found clever way to fix decimal issues. Things are tested and working.

478450e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Currency validation: Addressing bug found by @ellevargas #27

Currency validation: Addressing bug found by @ellevargas #27

Trishthedish commented Oct 28, 2016

Currency validation: Addressing bug found by @ellevargas #27

Are you sure you want to change the base?

Currency validation: Addressing bug found by @ellevargas #27

Conversation

Trishthedish commented Oct 28, 2016