Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Erica Case - BankAccounts #22

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

EricaJCasePhD
Copy link

Bank Account

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Why is it useful to put classes inside modules? What do you think? 1. To prevent accidentally overwriting other classes with the same name. 2 .To create a higher levels of organization.
What is accomplished with raise ArgumentError? What do you think it's doing? Raise ArgumentError stops the run and puts hints as to what went wrong. I think it calls an if statement with "puts' and 'exit'.
Why do you think we made the .all & .find methods class methods? Why not instance methods? An instance method would refer to one specific account; this would be incredibly boring for the .all method and equivalent to just typing .id for the .find method.
Why does it make sense to use inheritance for the different types of accounts? All accounts
Did the presence of automated tests change the way you thought about the problem? How? Yes. I thought a lot more about the connections between files (ie why Ruby was getting so angry at me when I ran rake), and less about the actual code.

@PilgrimMemoirs
Copy link

Bank Account

What We're Looking For

Feature Feedback
Wave 1
All provided tests pass Well Done
Using the appropriate attr_ for instance variables Well Done
Wave 2
All stubbed tests are implemented fully and pass Well Done
Created instances (by calling new) in Account.all Well Done
Used CSV library only in Account.all (not in Account.find) Well Done
Used Account.all to get account list in Account.find Well Done
Wave 3
All stubbed tests are implemented fully and pass Well Done
Used inheritance in the initialize for both Checking and Savings Accounts (min balance) Well Done
Used inheritance for the withdraw in checking and savings accounts Well Done
Baseline
Used Git Regularly Should commit more regularly. Commit with every new change that's working.
Answer comprehension questions Looks good, but 4th question should be answering the 'why'.
Extras Overall, everything looks great and perfectly meets the expectations for this project. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants