Code

Lynn Trickey's Bank Account#23

Code

Open

ltrickey wants to merge 74 commits intoAda-C7:masterAda-C7/BankAccounts:masterfrom ltrickey:masterCopy head branch name to clipboard

+692-43

Commits

Commits on Feb 21, 2017

• Created module of Bank, class Account

  ltrickey

  committed
  d7417a8

  Copy full SHA for d7417a8

• Initialize Bank::Account with Id & Balance

  ltrickey

  committed
  41b83ad

  Copy full SHA for 41b83ad

• Cannot initialize with Negative Bal

  ltrickey

  committed
  196a3ff

  Copy full SHA for 196a3ff

• Creating method withdraw for class Account

  ltrickey

  committed
  5dfdf17

  Copy full SHA for 5dfdf17

• withdrawl returns updated balance

  ltrickey

  committed
  038cea7

  Copy full SHA for 038cea7

• Outputs an error if balance is going negative.

  ltrickey

  committed
  6fbb0be

  Copy full SHA for 6fbb0be

• Doesn't modify balance if withdrawl would make it go negative.

  ltrickey

  committed
  ecb4b4e

  Copy full SHA for ecb4b4e

• Allows withdrawal ammount to = balance, taking balance to 0.

  ltrickey

  committed
  2a47fc2

  Copy full SHA for 2a47fc2

• withdrawal must be > 0

  ltrickey

  committed
  f2a4678

  Copy full SHA for f2a4678

• Add deposit method

  ltrickey

  committed
  a8c0232

  Copy full SHA for a8c0232

• deposit adds to balance

  ltrickey

  committed
  2434062

  Copy full SHA for 2434062

• Raise argument if deposit is not positive

  ltrickey

  committed
  c8807a3

  Copy full SHA for c8807a3

• Add Owner class

  ltrickey

  committed
  c40d49b

  Copy full SHA for c40d49b

Commits on Feb 22, 2017

• Adding test to make sure Owner can be initialized

  ltrickey

  committed
  8cc4450

  Copy full SHA for 8cc4450

• initialize class Owner with Name and Phone Number

  ltrickey

  committed
  7d7aec9

  Copy full SHA for 7d7aec9

• Updated test and account to make sure Owner responded to name and phone methods

  ltrickey

  committed
  fe8c680

  Copy full SHA for fe8c680

• Starting a test to check if a new Owner can be assigned to an Account

  ltrickey

  committed
  a871c20

  Copy full SHA for a871c20

• Added @owner attribute to Account class. Tested that it is accessible

  ltrickey

  committed
  d6ea6ef

  Copy full SHA for d6ea6ef

• Adding owner of object Owner, modifying test to reflect

  ltrickey

  committed
  0de7ef1

  Copy full SHA for 0de7ef1

• Create test to check that owner parameter when calling add_owner on an Account must be type Owner.

  ltrickey

  committed
  5a31f07

  Copy full SHA for 5a31f07

• owner parameter must be class Owner when calling add_owner on Account class

  ltrickey

  committed
  ce6f236

  Copy full SHA for ce6f236

• Adding stubs of .all class method for Account

  ltrickey

  committed
  d8b8b00

  Copy full SHA for d8b8b00

• change account.initialize to take in third parameter of opendate

  ltrickey

  committed
  cdc812f

  Copy full SHA for cdc812f

• Modifying specs to work with new three parameters required to initialize instance of Account

  ltrickey

  committed
  b4037b3

  Copy full SHA for b4037b3

• Change default initial value of datetime to nodate so tests still work

  ltrickey

  committed
  5010f43

  Copy full SHA for 5010f43

• wrote test to verify .add returns array

  ltrickey

  committed
  5d11fbe

  Copy full SHA for 5d11fbe

• adding before do block to Account.all test portion

  ltrickey

  committed
  912cf0d

  Copy full SHA for 912cf0d

• created test to verify that every item in array returned with .all method is a class Bank::Account

  ltrickey

  committed
  38abc1b

  Copy full SHA for 38abc1b

• completed test that made sure first id in CSV matched first id in .all method

  ltrickey

  committed
  b9c04aa

  Copy full SHA for b9c04aa

• added check balance to last spec

  ltrickey

  committed
  efe448e

  Copy full SHA for efe448e

• created test to return an existing account class account

  ltrickey

  committed
  aeaa3a2

  Copy full SHA for aeaa3a2

Commits on Feb 23, 2017

• Create Self method to return object of account when specific id is called.

  ltrickey

  committed
  393e1f6

  Copy full SHA for 393e1f6

• created and passed tests for finding first and last account from CSV

  ltrickey

  committed
  216b8ca

  Copy full SHA for 216b8ca

• edited .find class method to raise error if searching for id that does not exist. created & passed test.

  ltrickey

  committed
  0aa8c67

  Copy full SHA for 0aa8c67

• updating Owner class to take inputs available in CSV file

  ltrickey

  committed
  55ab30c

  Copy full SHA for 55ab30c

• Updated Owner class to have default values of nil, wrote test for Owner class

  ltrickey

  committed
  7aedbd8

  Copy full SHA for 7aedbd8

• Created and passed test to verify Owner class method .all returns array.

  ltrickey

  committed
  e567bd6

  Copy full SHA for e567bd6

• Added stumps for further .all tests

  ltrickey

  committed
  d1ed52a

  Copy full SHA for d1ed52a

• updating Owner tests. Working through line 208 which is commented out. All else working.

  ltrickey

  committed
  3638954

  Copy full SHA for 3638954

• add test to check first and last street_address & pass

  ltrickey

  committed
  fc909b2

  Copy full SHA for fc909b2

• added .find(id) class method for Owner & test

  ltrickey

  committed
  31adb29

  Copy full SHA for 31adb29

• Adding argument error if Owner ID does not exist for Owner.find. Created & passed test

  ltrickey

  committed
  158f632

  Copy full SHA for 158f632

• Calling .length on CSV read file instead of creating variable to count the length - clean up

  ltrickey

  committed
  f311fbf

  Copy full SHA for f311fbf

• set up stubs for CheckingAccount and SavingsAccount classes

  ltrickey

  committed
  23ab6cc

  Copy full SHA for 23ab6cc

• Add Savings account functionality that intial balance must be > 10

  ltrickey

  committed
  abb53f1

  Copy full SHA for abb53f1

• Add fee for each withdrawal

  ltrickey

  committed
  fb8fa1b

  Copy full SHA for fb8fa1b

• Outputs warning if withdrawal will take Savings Account balance below 0 & does not affect balance

  ltrickey

  committed
  e062ad2

  Copy full SHA for e062ad2

• create withdrawal for savings that does not withdraw if fee will take it below 10

  ltrickey

  committed
  9c207c5

  Copy full SHA for 9c207c5

Commits on Feb 24, 2017

• define add interest method

  ltrickey

  committed
  f72b5f2

  Copy full SHA for f72b5f2

• Updated method of add_interest to take parameter of interest rate

  ltrickey

  committed
  cf30c41

  Copy full SHA for cf30c41

• Interest rate must be positive.made all required edits

  ltrickey

  committed
  5fbc907

  Copy full SHA for 5fbc907

• Add dollar fee for withdrawals from checking account

  ltrickey

  committed
  5fea827

  Copy full SHA for 5fea827

• Doesn't modify balance if fee would take it under 0, test works

  ltrickey

  committed
  c78c827

  Copy full SHA for c78c827

• Created basic check_withdrawal method

  ltrickey

  committed
  3c0614b

  Copy full SHA for 3c0614b

• Make sure withdraw_with_check returns balance

  ltrickey

  committed
  c4371ff

  Copy full SHA for c4371ff

• allows check withdrawals to go up to -10

  ltrickey

  committed
  99db3d4

  Copy full SHA for 99db3d4

• Won't allow more than -10 balance, outputs message for check withdrawals

  ltrickey

  committed
  b01fad3

  Copy full SHA for b01fad3

• check withdrawals must be positive

  ltrickey

  committed
  5419107

  Copy full SHA for 5419107

• WIP - working on adding the class var @@check_withdrawals. Code currently broken :(

  ltrickey

  committed
  aa8601f

  Copy full SHA for aa8601f

• Just adding everything so I'm up to date. Still WIP

  ltrickey

  committed
  1e56388

  Copy full SHA for 1e56388

• fixed var check_withdrawals to be instance variable NOT class v.

  ltrickey

  committed
  649ec52

  Copy full SHA for 649ec52

• created and tested reset-checks method

  ltrickey

  committed
  af30766

  Copy full SHA for af30766

• Added set_balance method to start. Trying to turn instance vars of @balance into calling the method throughout code. WIP

  ltrickey

  committed
  8ef02b9

  Copy full SHA for 8ef02b9

• Adding files and stumps of Money Market account & spec files

  ltrickey

  committed
  d7b5061

  Copy full SHA for d7b5061

• Money Market account initialize & set balance methods done

  ltrickey

  committed
  b4a13e3

  Copy full SHA for b4a13e3

• got total transactions for Money Market to stop after 6

  ltrickey

  committed
  4f4d00e

  Copy full SHA for 4f4d00e

• edited withdraw method for MMarket, preventing any withdrawals if balance is less than 10k

  ltrickey

  committed
  92f50fb

  Copy full SHA for 92f50fb

• Added test for counting total transactions. Failing

  ltrickey

  committed
  88221b9

  Copy full SHA for 88221b9

• Passing total transactions test

  ltrickey

  committed
  11a61ed

  Copy full SHA for 11a61ed

• created reset transactions method & tested

  ltrickey

  committed
  a2ddadf

  Copy full SHA for a2ddadf

• created add interest for money market account

  ltrickey

  committed
  12b55a5

  Copy full SHA for 12b55a5

• trying to dry up code w/ argument method

  ltrickey

  committed
  78e4fe2

  Copy full SHA for 78e4fe2

• pulling out fees for withdrawals and creating them as their own methods

  ltrickey

  committed
  970e88c

  Copy full SHA for 970e88c

Commits on Feb 27, 2017

• Added in Interest module to practice Object Comparison

  ltrickey

  committed
  1754f3b

  Copy full SHA for 1754f3b