Queues - Kayla Kubicke - Bank Accounts

[ghost]

Bank Account

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
Why is it useful to put classes inside modules? What do you think?	Putting classes inside a module allows you organize your classes (and their names) in some fashion.
What is accomplished with raise ArgumentError? What do you think it's doing?	A 'raise ArgumentError', as far as I understand it, basically stops the program from executing in a situation were it really shouldn't.
Why do you think we made the .all & .find methods class methods? Why not instance methods?	All of the accounts, including the inherited ones, needed the 'traits' inside those two methods.
Why does it make sense to use inheritance for the different types of accounts?	The accounts have similar properties and inheritance allows you to grab 'the basics' of the parent class and then customize as you wish.
Did the presence of automated tests change the way you thought about the problem? How?	Yes, very much so. I had to think about the interaction going on between the program and the tests. It was frustrating, but ultimately helpful.

[droberts-sea]

Bank Account

What We're Looking For

Feature	Feedback
Wave 1
All provided tests pass	yes
Using the appropriate attr_ for instance variables	yes
Wave 2
All stubbed tests are implemented fully and pass	yes
Created instances (by calling new) in Account.all	yes
Used CSV library only in Account.all (not in Account.find)	yes
Used Account.all to get account list in Account.find	yes
Wave 3
All stubbed tests are implemented fully and pass	no - some are skipped, and one fails
Used inheritance in the initialize for both Checking and Savings Accounts	yes
Used inheritance for the withdraw in checking and savings accounts	no - see inline comment
Baseline
Used Git Regularly	I like how frequently you've been committing, but in the future I would like to see more descriptive commit messages. Try and capture what you accomplished and why, and how the code is different than it was before.
Answer comprehension questions	yes

Outside of a couple of parts of Wave 3, this looks solid. Good work!

[droberts-sea]

Nice use of before!

[droberts-sea]

Why is this MoneyMarketAccount - I would have expected to see CheckingAccount in this file (and that's what you appear to have implemented).

[droberts-sea]

It might be cleaner to use super here to call Account#withdraw, and centralize your logic all in one place. In this case Account#withdraw would probably require more parameters, like a fee and a minimum balance.

[droberts-sea]

I like that you used a times loop here to DRY up this code. Good work!