Queues - Danielle Birbal - MediaRanker

[birbalds]

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I did not write a model method
Describe how you approached testing that model method. What edge cases did you come up with?
Describe an edge case test you wrote for a controller	I tested for bogus data and invalid data.
What are session and flash? What is the difference between them?	A 'session' allows you to store data during one request to be used in later requests. While 'flash' temporarily passes a string/array/hash to the next action and then cleared.
Describe a controller filter you wrote.
What was one thing that you gained more clarity on through this assignment?	Validations and Relationships have gotten more comprehendible.
What is the Heroku URL of your deployed application	https://dank-rank.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?

[PilgrimMemoirs]

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Well Done
Comprehension questions	If you did not complete something, say what you would have done in the answer.
General
Rails fundamentals (RESTful routing, use of named paths)	Well done
Semantic HTML	Mostly good - Not all element are nested in a sectioning tag. Also be mindful of indentation
Errors are reported to the user	Well Done
Business logic lives in the models	No model methods - logic is mixed too much in views and controller - organizing a list of ten media types should be a model method
Model testing	Well Done - would like to see fixtures used in future (like with bEtsy)
Controller testing	Well Done
Wave 1 - Media
Splash page shows the three media categories	Well Done
Basic CRUD operations on media are present and functional	Well Done
Wave 2 - Users and Votes
Users can log in and log out	Well Done
The ID of the current user is stored in the session	Well Done
Individual user pages and the user list are present	Well Done
A user cannot vote for the same media more than once	Well Done
All media lists are ordered by vote count	Well Done
Splash page contains a media spotlight	Well Done
Media pages contain lists of voting users	Well Done
Wave 3 - Styling
Foundation is used appropriately	Well Done
Look and feel is similar to the original	Well Done
Overall

A few things that were not complete that should be worked on in bEtsy: Testing with Fixtures, creating custom model methods, making sure all html code is properly indented and all html elements are organized into semantic sectioning tags