Haby's Media Ranker

[habypsow]

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I have not yet written a custom model method, but I plan on submitting more commits over the weekend, and will follow up to this question
Describe how you approached testing that model method. What edge cases did you come up with?	I have not yet written this method, I will come back to this as well.
Describe an edge case test you wrote for a controller	When an element does not exist in the database, you would be directed to a no content page message.
What are session and flash? What is the difference between them?	Session is the process of user authentication into a site, and the data persists until the user closes their browser or when they log out. A flash is a message that is sent from the controller to the browser, with specific messages about an action (successful or not). This information only persists up to the current cycle, depending on whether flash, or flash.now was used.
Describe a controller filter you wrote.	N/A, lecture postponed.
What was one thing that you gained more clarity on through this assignment?	I think writing custom routes became clearer, as well as using fixtures for testing!
What is the Heroku URL of your deployed application	https://haby-media-ranker.herokuapp.com/ (It is not pretty yet, don't judge me :) )
Do you have any recommendations on how we could improve this project for the next cohort?	I am not sure if it is because I got sick this week, but this was a tough week for me. I do feel like I could have used more time, or maybe had the weekend to work over this project without the major monthly assessment. I am submitting work that is not yet complete, but will work on this over the weekend and add more commits :) I do feel anxious right now submitting incomplete work, and so more time would have been appreciated.

[CheezItMan]

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	A good number of commits and branches used.
Comprehension questions	Answered, I realize you had a hard week especially with your illness.
General
Rails fundamentals (RESTful routing, use of named paths)	Check
Semantic HTML	Check, but I would group your item like in your works/index.html.erb page in container tags like section or article etc just to enforce logical grouping, and to make them easier to style later.
Errors are reported to the user	Check, but for some reason I see the successful message and then the unsuccessful message when I hit upvote twice in a row.
Business logic lives in the models	Good use of the top-10 method. I would also create a spotlight method and a method for voting.
Model testing	Some testing needed in the User & Vote models.
Controller testing	The upvote method testing should also require the user to log in first. Votes Controller, Sessions and Users controller need to be completed. For the Work controller you should also test for deleting a work which doesn't exist (like deleting a work twice). In general you should be testing for invalid data.
Wave 1 - Media
Splash page shows the three media categories	Check
Basic CRUD operations on media are present and functional	Check, but the category should be in the URL and use to automatically select the category.
Wave 2 - Users and Votes
Users can log in and log out	Check
The ID of the current user is stored in the session	Check
Individual user pages and the user list are present	Check, well done
A user cannot vote for the same media more than once	Check
All media lists are ordered by vote count	No, you can use ActiveRecord's order method to order elements by a field.
Splash page contains a media spotlight	The field is there, but not filled in.
Media pages contain lists of voting users	Check
Wave 3 - Styling
Foundation is used appropriately	Foundation is applied, but the layout isn't there, and the fonts etc could use some work.
Look and feel is similar to the original	The layout & the fonts needed work.
Overall	Considering the heath issues you had, not bad. You covered the essentials, but need practice with Foundation layout, flash messages and using .order to sort the items. Most importantly I encourage you to focus on through testing.