Alison Z's mediaranker - kinda

[AlisonZ]

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	A custom method I wrote was 'upvote' in the votes controller. It looks to see if a vote object has the user id of the user logged into the current session and work id. If a match is found between these three things, it means the user has previously voted for that vote and is not allowed to vote again.
Describe how you approached testing that model method. What edge cases did you come up with?	Did not get there. I guess I would just test to a vote that has not happened and a vote that has happened and a not logged in user trying to vote
Describe an edge case test you wrote for a controller	Gives a 404 error if a user tries to go to the show page of a nonexistent object
What are session and flash? What is the difference between them?	Flash sends a one-time message to the view and does so from the controller,session is a temporary object that is available until the user or program ends the session through a controller or the browser is closed
Describe a controller filter you wrote.	I did not write any. Honestly, I don't remember learning about them, so I'm glad this question was here and made me re-read the notes.
What was one thing that you gained more clarity on through this assignment?	What PARAMS are!!! yay!! It clicked!
What is the Heroku URL of your deployed application	https://guarded-bayou-99368.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	Scale it down. The project itself was daunting and then it was also a challenge for us to go out on our own. It felt like a big jump from the last weeks of holding out hand through guided steps on individual projects. And being forced to do it on our own is necessary and a good challenge, but it felt like too much at once with a project with this scope. I would say in the future either make this project be about a whole bunch of concepts coming together with more pointed steps walking the students through it, or scale is back and add less new concepts, so the students can practice a managing and planning a project on their own

[CheezItMan]

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	A good number of commits given how far you got in the project. You should be using branches as you work on different features.
Comprehension questions	You should have an upvote method in the model and put most of the business logic there instead of the controller.
General
Rails fundamentals (RESTful routing, use of named paths)	The routes are there, but a lot of functionality is missing, such as being able to create a work. You also cannot edit a work.
Semantic HTML	Some semantic HTML used in the layout, and good use of unordered lists in the index views.
Errors are reported to the user	Errors are reported with flash.
Business logic lives in the models	Very little business logic is in the models. Offhand you should probably have the upvote, spotlight and ranking functionality in the models.
Model testing	None
Controller testing	None
Wave 1 - Media
Splash page shows the three media categories	Check
Basic CRUD operations on media are present and functional	Index and show are working
Wave 2 - Users and Votes
Users can log in and log out	Check
The ID of the current user is stored in the session	Check
Individual user pages and the user list are present	Not present
A user cannot vote for the same media more than once	Check
All media lists are ordered by vote count	The media aren't ordered by vote count.
Splash page contains a media spotlight	Not present
Media pages contain lists of voting users	Not present
Wave 3 - Styling
Foundation is used appropriately	None
Look and feel is similar to the original	No CSS
Overall	There's a lot not finished here. This is a bit concerning. Even functionality from previous projects isn't working.