Media-Ranker

[botrethewey]

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I made a class method self.spotlight for the Work model to determine the first work object with the most vote count.
Describe how you approached testing that model method. What edge cases did you come up with?	I tested each model for validity, then I tested for appropriate entity relationship and custom methods when applicable. For self.spotlight custom method for work, I checked for the edge case where none of the work objects have a vote yet, which should result in random selection from the existing work objects in the database.
Describe an edge case test you wrote for a controller	I tested for an edge case for Vote controller, where the user tries to upvote a work object before logging in.
What are session and flash? What is the difference between item?	Session and Flash are special hash-like objects that contain messages for display. While Session messages persist from one one request to another, Flash messages are used only once per request.
Describe a controller filter you wrote.	I did not use any controller filters in this project.
What was one thing that you gained more clarity on through this assignment?	This project helped me practice using custom methods and using dynamic routes. Given more time, I would like to use more methods to dry up my code more.
What is the Heroku URL of your deployed application	https://bo-media-ranker.herokuapp.com
Do you have any recommendations on how we could improve this project for the next cohort?	I think this project would have been easier if we had more in-class practice with testing...and of course, having more time to work on it. I would love to see other examples of this project, especially examples using the controller filters.

[CheezItMan]

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good regular commit and several branches, good work!
Comprehension questions	Check
General
Rails fundamentals (RESTful routing, use of named paths)	Check
Semantic HTML	Check, however I would wrap the flash messages inside a section or article element.
Errors are reported to the user	Check, good use of flash.
Business logic lives in the models	Yes with one method, but I would also create a method to add votes, and get the top 10 of any category.
Model testing	Check, I did notice you misspelled "invalid," but that's a nitpick.
Controller testing	I would look to Dry up your controller tests since you have several identical categories being tested. For the sessionsController, you should also test that the number of users increase for a new user's login.
Wave 1 - Media
Splash page shows the three media categories	Check
Basic CRUD operations on media are present and functional	Check
Wave 2 - Users and Votes
Users can log in and log out	Check
The ID of the current user is stored in the session	Check
Individual user pages and the user list are present	Check
A user cannot vote for the same media more than once	Check
All media lists are ordered by vote count	Check
Splash page contains a media spotlight	Check
Media pages contain lists of voting users	Check
Wave 3 - Styling
Foundation is used appropriately	Check
Look and feel is similar to the original	Very close
Overall	Really nice work, This was a very tough project and you did a nice job on it!