Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Hyunji Kim - MediaRanker #30

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

ricecakemonster
Copy link

@ricecakemonster ricecakemonster commented Apr 16, 2017

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a custom model method you wrote. I made a model method to make the entered username lower case. Everything else is in either view files or controller files.
Describe how you approached testing that model method. What edge cases did you come up with? it allows to create a work with the already existing title as long as the new work is created under a different category from the existing work.
Describe an edge case test you wrote for a controller works#destroy. When a work gets deleted, the votes that belongs to that work should be deleted as well.
What are session and flash? What is the difference between them? Both of them are special hash like objects. A session is created when a user logs in. It ends when the user logs out. A flash is a message that displays on the user's screen only once according to user's action. If the user refreshes the screen, it disappears . Example of a flash: "Successfully logged out"
Describe a controller filter you wrote. We didn't learn it yet.
What was one thing that you gained more clarity on through this assignment? Everything about rails. I feel more comfortable dealing with all the different files at the same time now.
What is the Heroku URL of your deployed application http://hyunmediaranker.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort? MediaRanker is a big project. It will be nice to give more in-class project time.

…og in and create new user are not case sensitive now.
@PilgrimMemoirs
Copy link

Media Ranker

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Well Done
Comprehension questions Well Done - How come session is used for logging in? What makes it different from flash?
General
Rails fundamentals (RESTful routing, use of named paths) Well Done
Semantic HTML Well Done
Errors are reported to the user Mostly Good
Business logic lives in the models Sometimes - Logic, like lines 4-6 in main controller's index method, should be a model method
Model testing Some - Need tests for edge cases and more for user
Controller testing Well Done
Wave 1 - Media
Splash page shows the three media categories Well Done
Basic CRUD operations on media are present and functional Well Done
Wave 2 - Users and Votes
Users can log in and log out Well Done
The ID of the current user is stored in the session Well Done
Individual user pages and the user list are present Well Done
A user cannot vote for the same media more than once Well Done
All media lists are ordered by vote count Well Done
Splash page contains a media spotlight Well Done
Media pages contain lists of voting users Well Done
Wave 3 - Styling
Foundation is used appropriately Well Done
Look and feel is similar to the original Well Done
Overall
Great work including all the main functionality and achieving an nearly duplicate application from the example!
To display 10 on the first page, should create a model method that will return only 10 instances by the number of votes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants