Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Cynthia Cobb - Media Ranker #33

Open
wants to merge 100 commits into
base: master
Choose a base branch
from

Conversation

cynthiacd
Copy link

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a custom model method you wrote. wrote custom methods for the Work model to find top 10 books, movies, and albums
Describe how you approached testing that model method. What edge cases did you come up with? I had three tests and tested that it returned a collection of items, returned between 0 and 10 and returned nil when there were no works. My edge case was testing when there are no works
Describe an edge case test you wrote for a controller Made sure to test that the routes and page were still successful when there were no works for each category
What are session and flash? What is the difference between them? flash allows you to flash messages to the user - session allows you to track a user and determine if they are logged in
Describe a controller filter you wrote. I did not use a filter method
What was one thing that you gained more clarity on through this assignment? helper methods and how to test
What is the Heroku URL of your deployed application https://immense-everglades-99115.herokuapp.com/books?
Do you have any recommendations on how we could improve this project for the next cohort? Include a list of topics you can research, on your own, that could help with design. For example routing constraints, filters, and helper-methods

@PilgrimMemoirs
Copy link

Media Ranker

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Well Done
Comprehension questions Well Done - be more specific w/ flash and hash, like what data structure are they and why would you use one over the other?
General
Rails fundamentals (RESTful routing, use of named paths) Well done
Semantic HTML Well Done
Errors are reported to the user Well Done
Business logic lives in the models Well Done - work model could utilize a single method to handle the top ten methods.
Model testing Well done - I see you made fixtures but did not use them in the tests - which :let methods could you remove and use your fixture instead?
Controller testing Well Done
Wave 1 - Media
Splash page shows the three media categories Well Done
Basic CRUD operations on media are present and functional Well Done
Wave 2 - Users and Votes
Users can log in and log out Well Done
The ID of the current user is stored in the session Well Done
Individual user pages and the user list are present Well Done
A user cannot vote for the same media more than once Well Done
All media lists are ordered by vote count Well Done
Splash page contains a media spotlight Well Done
Media pages contain lists of voting users Well Done
Wave 3 - Styling
Foundation is used appropriately Well Done
Look and feel is similar to the original Well Done
Overall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants