Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacks - Jackie - Media Ranker #39

Open
wants to merge 66 commits into
base: master
Choose a base branch
from

Conversation

jackiewatanabe
Copy link

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a custom model method you wrote. I wrote custom models methods for the Work model to sort works by category/votes and to choose the top ten for each category as well as the number one work
Describe how you approached testing that model method. What edge cases did you come up with? I didn't get around to testing the custom method :(
Describe an edge case test you wrote for a controller in the movies controller, I tested to make sure no new objects were added to the database if invalid data was entered
What are session and flash? What is the difference between them? session and flashes are special hashes. Flash stores one-time messages. Session stores information about the user and that information stays until the user closes their browser or the data is manually removed.
Describe a controller filter you wrote. ???
What was one thing that you gained more clarity on through this assignment? That you can have more controllers than you have models in an application.
What is the Heroku URL of your deployed application https://mysterious-beyond-38414.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?

…d correctly and show up on corresponding indexes
…changed Works index to inherit method from application controller
…spotlight media to choose work with most votes
…made sure the new view displays the specific errors
…so that other files that were created along with controller get deleted too
…added second error condition so that it would display in bullet form
@kariabancroft
Copy link

Media Ranker

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Looks good
Comprehension questions Yes
General
Rails fundamentals (RESTful routing, use of named paths) Yes
Semantic HTML Not too much - though you used it on the index and show pages
Errors are reported to the user Yes - using flash. It would be good to practice using the status codes for other error scenarios.
Business logic lives in the models Yes - some methods to retrieve specific items in the work model
Model testing Yes - nice job checking validity and the errors
Controller testing Yes - you got good practice with this syntax and trying out a variety of controller actions
Wave 1 - Media
Splash page shows the three media categories Yes
Basic CRUD operations on media are present and functional Yes
Wave 2 - Users and Votes
Users can log in and log out Yes
The ID of the current user is stored in the session Yes
Individual user pages and the user list are present Yes - looks great!
A user cannot vote for the same media more than once Yes - nice job implementing this feature
All media lists are ordered by vote count Yes - great
Splash page contains a media spotlight Yes
Media pages contain lists of voting users Yes
Wave 3 - Styling
Foundation is used appropriately Yes
Look and feel is similar to the original Yes
Overall You did a really nice job with the features of this application, hitting the testing learning goals and exploring foundation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants