Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Sahana Murthy - Media Ranker #40

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

sahanamurthy
Copy link

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a custom model method you wrote. I did not write any custom model methods. If I did, I probably would have written a method to help identify the item with the most amount of votes.
Describe how you approached testing that model method. What edge cases did you come up with? I did not test the models. If I did, I would have tested each of the relationships described in the models, and also validations.
Describe an edge case test you wrote for a controller I did not write any tests for controllers. If I did, the edge case test would have likely tested parameters.
What are session and flash? What is the difference between them? Flash is a hash that is used to send messages from controllers to views. Session is a hash that is used to keep track of data throughout a user's session (after a login has occurred). The difference between them is that the flash messages disappear after the browser goes to a different page or refreshes. A session remains active until a user has logged out.
Describe a controller filter you wrote. I did not write any controller filters.
What was one thing that you gained more clarity on through this assignment? I learned how to use multiple models within a controller. I also learned how to customize routes.
What is the Heroku URL of your deployed application https://sahana-media-ranker.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort? Please take out some of the requirements. :( Or offer a bit more guidance on how to approach the multiple controllers/customized routes. Both of those things combined with testing was a bit difficult to handle, but only because it was a stage 2 project. The requirements would have been easier to meet if it was treated more like a stage 1 project. Or if we were offered more time to work on it. Like 2 weeks.

@droberts-sea
Copy link

Media Ranker

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions yes
General
Rails fundamentals (RESTful routing, use of named paths) yes
Semantic HTML yes
Errors are reported to the user no - without any model validations this probably wouldn't have come up
Business logic lives in the models no - a few good candidates include: selecting the top item by vote count, and selecting the top ten items from a given category in order by number of votes
Model testing no
Controller testing no
Wave 1 - Media
Splash page shows the three media categories yes
Basic CRUD operations on media are present and functional yes
Wave 2 - Users and Votes
Users can log in and log out yes
The ID of the current user is stored in the session yes
Individual user pages and the user list are present yes
A user cannot vote for the same media more than once yes
All media lists are ordered by vote count no
Splash page contains a media spotlight no
Media pages contain lists of voting users no
Wave 3 - Styling
Foundation is used appropriately yes
Look and feel is similar to the original pretty close
Overall

Good work overall! This project was quite big with many moving parts, and while it may feel like you left a lot out much of the core functionality is there. I'm especially happy with the interactions between users and voting - it worked exactly as I expected it to.

With the remainder of bEtsy, make sure you spend some time working on models:

  • Writing validations, and reporting errors to the user
  • Writing custom class methods to perform interesting selections
  • Testing both of the above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants