Queues Laura's MediaRanker

[lmelgarejos]

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	validates the presence of title in order to create a new work, and the title should be unique.
Describe how you approached testing that model method. What edge cases did you come up with?	I tested that when a work has a title is valid, a work without title is not valid, and finally I made sure to test the uniqueness assigning the same title to two works and testing that the 2nd one is not valid.
Describe an edge case test you wrote for a controller	I tested the method create to make sure that the validations in the model where being apply. To test this method with an edge case, first I counted all the Works in the data base, and set the value to a variable. second, I send a post request in order to create a new work and finally I count again all the works and make sure that it is plus 1 from the original. To test this method's validation I used the same logic but pass wrong params and the final count needed to be equal as the one before the post request.
What are session and flash? What is the difference between them?	messages display on the page, flash lasts only until the page is refresh, and session will last until the session's logged off or when the page is closed.
Describe a controller filter you wrote.	...
What was one thing that you gained more clarity on through this assignment?	Rails made sence this week rather than the others. I gained more clarity where to put what in the different files.
What is the Heroku URL of your deployed application	https://laura-media-ranker.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	I really like the introduction in this project of session and flash, but the project is a little long. Perhaps a little bit less functionalities in order to make the project shorter.

[droberts-sea]

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	yes
Comprehension questions	yes
General
Rails fundamentals (RESTful routing, use of named paths)	yes
Semantic HTML	yes - there are places where you could probably DRY it up using partials, for example the show_category and new_category pages
Errors are reported to the user	yes - good work!
Business logic lives in the models	no - good candidates would be the logic to get the top 10 media for a given category sorted by vote count, and the logic to find the spotlight media
Model testing	This is a good start, but I would like to see tests that probe a little deeper. For example, when testing validations you should check errors.messages to see if it includes a message about the field you're expecting. Of course, as you move more logic into your models you'll need to add more tests.
Controller testing	yes - good work!
Wave 1 - Media
Splash page shows the three media categories	yes
Basic CRUD operations on media are present and functional	yes
Wave 2 - Users and Votes
Users can log in and log out	yes
The ID of the current user is stored in the session	yes
Individual user pages and the user list are present	yes
A user cannot vote for the same media more than once	yes
All media lists are ordered by vote count	no
Splash page contains a media spotlight	no
Media pages contain lists of voting users	yes
Wave 3 - Styling
Foundation is used appropriately	yes
Look and feel is similar to the original	yes
Overall

Great work overall! MediaRanker is a complex project with many moving parts, and it seems like you really rose to the challenge. The one thing I'd like you to make sure you practice in bEtsy is moving logic into the model - this might include interesting actions on an individual model object, or a class method that selects a certain set of models from the database.