Queues - Janice Lichtman - Media Ranker

[J-C-L]

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I wrote a class method called spotlight in the items controller, which returns the item with the most votes.
Describe how you approached testing that model method. What edge cases did you come up with?	I tested that the method returned an object of the right type (Item), and that it returned the item with the most votes. An edge case I tested was if there was a tie for the most votes. I tested that my method returned the first highest vote-getter.
Describe an edge case test you wrote for a controller	When I tested the index_by_category action in my items controller, an edge case i tested was checking that no error happened when a category had no items
What are session and flash? What is the difference between them?	session and flash are both hash-like objects that can be used in rails. Session persists through requests cycles until is it reset/overwritten, so can be used to track a desire persistent state, like login status. Flash only retains data for the given cycle, so can be used to track and display one-time pieces of information (like a failure message)
Describe a controller filter you wrote.	We didn't cover controller filters until the following week.
What was one thing that you gained more clarity on through this assignment?
What is the Heroku URL of your deployed application	https://mediaranker-janice.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	Its ALOT for a one week project. Many many details and many many new pieces.

[droberts-sea]

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	yes
Comprehension questions	yes
General
Rails fundamentals (RESTful routing, use of named paths)	yes
Semantic HTML	mostly - in some places content isn't wrapped in a sectioning tag
Errors are reported to the user	yes - good work!
Business logic lives in the models	yes - good work!
Model testing	good start - I would like to see more failure cases for your model methods. What happens if there are no Items, or if no Item matches the requested category?
Controller testing	good start - would like to at least see full tests on the ItemsController
Wave 1 - Media
Splash page shows the three media categories	yes
Basic CRUD operations on media are present and functional	yes
Wave 2 - Users and Votes
Users can log in and log out	yes
The ID of the current user is stored in the session	yes
Individual user pages and the user list are present	yes
A user cannot vote for the same media more than once	yes
All media lists are ordered by vote count	yes
Splash page contains a media spotlight	yes
Media pages contain lists of voting users	yes
Wave 3 - Styling
Foundation is used appropriately	yes
Look and feel is similar to the original	yes
Overall

Great work overall! Thanks for putting in the time and effort on this, despite not having it ready on time. MediaRanker is a big project with many moving parts, but I'm really happy with what I see here. Make sure you spend some time focused on model and controller testing, particularly around edge and failure cases - forcing yourself to follow your code all the way through and predict how things could go wrong is a wonderful tool for improving your understanding.