Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Tamiko Terada - MediaRanker #49

Open
wants to merge 69 commits into
base: master
Choose a base branch
from
Open

Conversation

TamikoT
Copy link

@TamikoT TamikoT commented Apr 23, 2017

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a custom model method you wrote. I wrote model methods to divvy up media by type.
Describe how you approached testing that model method. What edge cases did you come up with? Make sure that the item returned by the method has the expected type. An edge case would be that it returns nil if a work with that media_type does not exist.
Describe an edge case test you wrote for a controller For WorksController testing, I wrote an edge case where invalid data returns a bad_request.
What are session and flash? What is the difference between them? A session in Rails holds on to information from the user in a hash-like object that exists across different HTTP requests. A flash is very similar to a session but only exists for the duration of one HTTP request.
Describe a controller filter you wrote. n/a
What was one thing that you gained more clarity on through this assignment?
What is the Heroku URL of your deployed application
Do you have any recommendations on how we could improve this project for the next cohort?

@droberts-sea
Copy link

Media Ranker

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions The ones you answered were good. I am interested if there was anything you gained clarity on, despite having struggled with it.
General
Rails fundamentals (RESTful routing, use of named paths) yes
Semantic HTML yes
Errors are reported to the user n/a
Business logic lives in the models yes - good work
Model testing yes
Controller testing yes, the functionality you have is well-tested
Wave 1 - Media
Splash page shows the three media categories yes
Basic CRUD operations on media are present and functional only Read and Delete
Wave 2 - Users and Votes
Users can log in and log out yes
The ID of the current user is stored in the session yes
Individual user pages and the user list are present no
A user cannot vote for the same media more than once n/a
All media lists are ordered by vote count n/a
Splash page contains a media spotlight n/a
Media pages contain lists of voting users n/a
Wave 3 - Styling
Foundation is used appropriately yes
Look and feel is similar to the original yes - good work!
Overall

Good work overall - this project was not nearly as incomplete as you led me to believe!

MediaRanker is quite big with many moving parts, and while it may feel like you left a lot out, I see a lot that I like. Your fundamentals (things under general above) seem strong, and your test coverage looks solid on features you implemented. You also did a good job working with Foundation, which is by no means easy.

For the remainder of bEtsy, I would like to see you take charge of at least one model/controller pair top to bottom. Something like categories might be a good option. Make sure you:

  • Implement all the core CRUD operations
  • Report any errors or validation failures to the user in a helpful manner
  • Build a complete test suite at both the model and the controller level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants