Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alisonz_solar_system.rb #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

alisonz_solar_system.rb #23

wants to merge 3 commits into from

Conversation

AlisonZ
Copy link

@AlisonZ AlisonZ commented Feb 15, 2017

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
What was the purpose of the initialize method in your class? To create an instance of the class
Describe an instance variable you used and what you used it for. They are supposed to be variables that can be accessed outside of the class and methods they were created in. Like, giving a planet a color instance variable in the Planet class and then using that variable in a method in the Solar System class.
Describe what the difference would be if your SolarSystem used an Array vs a Hash. One advantage of using a hash over an array is that you can access information like :color using the key instead of knowing which index the color information is stored in the array.
Do you feel like you used consistent indentation throughout your code? I tried!

@AlisonZ
Copy link
Author

AlisonZ commented Feb 15, 2017

Uhoh! Did I just mess up submitting this? I hope not!

This assignment was super hard for me and i feel like I am missing a crucial part. After a ton of hours and three re-writes, I can not get the information to print. I had it all working in arrays and then switching to hashes got me really confused. How do I access the values in a hash in planet from the solar system class?? i am going nuts over here! Looking forward to open tutoring!

@AlisonZ AlisonZ changed the title Create solar_system.rb alisonz_solar_system.rb Feb 15, 2017
@kariabancroft
Copy link

Solar System

What We're Looking For

I'll preface this feedback with the fact that we know we talked a bit about your code after you submitted it!

Feature Feedback
Created Custom Class with initialize method & instance variables. Yes. The instance variables on the Planet class are not appropriate. The planet_hash will always be nil the way it is currently implemented.
Used an Array to store a list of planets in the SolarSystem class. Yes. add_planet and add_planets methods are implemented appropriately.
Readable code with consistent indentation. Yes, code formatting looks good
Created a pull request with your name & a meaningful message. Almost! I'd like you to try again on the comprehension questions sometime this week. I think you are missing a few of the points we are looking for in there. We can also review together if you'd prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants